Skip to content

Specify array type via in_array#1430

Merged
ondrejmirtes merged 1 commit intophpstan:1.7.xfrom
rvanvelzen:in-array-type
Jun 17, 2022
Merged

Specify array type via in_array#1430
ondrejmirtes merged 1 commit intophpstan:1.7.xfrom
rvanvelzen:in-array-type

Conversation

@rvanvelzen
Copy link
Copy Markdown
Contributor

@rvanvelzen rvanvelzen marked this pull request as draft June 16, 2022 15:14
@herndlm
Copy link
Copy Markdown
Contributor

herndlm commented Jun 16, 2022

Oh, this was on my todo list as well :) I was hoping we could get rid of some of the specific in_array conditionals in ImpossibleCheckTypeHelper afterwards. Did you check already?

@rvanvelzen
Copy link
Copy Markdown
Contributor Author

I think so, I'll check tomorrow :)

@rvanvelzen rvanvelzen marked this pull request as ready for review June 17, 2022 07:53
@ondrejmirtes
Copy link
Copy Markdown
Member

Please send a clean-up in a next PR, I'm eager to see what else this fixes :) Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

in_array cannot be used as null check

3 participants