Retain accessory string types in generics #1096
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems to fix #6301. Inferring template types on intersection types is problematic because the bound type may not necessarily be a super type of all sub types of the passed intersection type
ondrejmirtes
requested changes
Mar 21, 2022
| require_once __DIR__ . '/../Rules/Generics/data/bug-3769.php'; | ||
| yield from $this->gatherAssertTypes(__DIR__ . '/../Rules/Generics/data/bug-3769.php'); | ||
|
|
||
| require_once __DIR__ . '/../Rules/Generics/data/bug-6301.php'; |
Member
There was a problem hiding this comment.
No need to require it. If it failed locally for you, you forgot to run composer dump before running the tests :)
ondrejmirtes
approved these changes
Mar 22, 2022
Member
|
Thank you! |
Member
|
BTW @rvanvelzen Can you please send a regression test for phpstan/phpstan#3951 ? NodeScopeResolverTest case that checks the type of |
Member
|
Sorry, correct link phpstan/phpstan#3951 |
Member
|
Oh, there are even more: phpstan/phpstan#6845 and phpstan/phpstan#5336 |
Contributor
|
Fyi, A regression test for phpstan/phpstan#5336 |
This was referenced Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems to fix phpstan/phpstan#6301. Inferring template types on intersection types is problematic because the bound type may not necessarily be a super type of all sub types of the passed intersection type.