Skip to content

REL: Prepare for the NumPy 1.24.2 release#23159

Merged
charris merged 1 commit intonumpy:maintenance/1.24.xfrom
charris:prepare-1.24.2-release
Feb 5, 2023
Merged

REL: Prepare for the NumPy 1.24.2 release#23159
charris merged 1 commit intonumpy:maintenance/1.24.xfrom
charris:prepare-1.24.2-release

Conversation

@charris
Copy link
Copy Markdown
Member

@charris charris commented Feb 4, 2023

  • Create 1.24.2-changelog.rst
  • Update 1.24.2-notes.rst

@charris charris added 14 - Release 36 - Build Build related PR labels Feb 4, 2023
@charris charris added this to the 1.24.2 release milestone Feb 4, 2023
@charris
Copy link
Copy Markdown
Member Author

charris commented Feb 4, 2023 •
edited
Loading

Reverting 30535f4 to see if that fixes things.

EDIT: That worked, so the source of the problem is localized to #22972, the backport of #22939.

@charris
Copy link
Copy Markdown
Member Author

charris commented Feb 4, 2023

The relevant differences to main seem to be in numpy/core/src/npymath/ieee754.cpp and numpy/core/src/npymath/ieee754.c,src, which do not define npy_nextafter in main. This is probably due to the npymath cleanup.

@charris
Copy link
Copy Markdown
Member Author

charris commented Feb 4, 2023

@mattip Thoughts?

@mattip
Copy link
Copy Markdown
Member

mattip commented Feb 4, 2023

hmm. Did we never try building wheels after #22972?

@charris
Copy link
Copy Markdown
Member Author

charris commented Feb 4, 2023

Did we never try building wheels after #22972?

Apparently not :) That's why I make sure to do that in these preparatory PRs. Note that the problem turned up when building wheels for m1.

@charris charris force-pushed the prepare-1.24.2-release branch from 0309fd7 to 77fc6cf Compare February 5, 2023 00:34
@charris
Copy link
Copy Markdown
Member Author

charris commented Feb 5, 2023

Undid the reversion to bring back the original so we can test solutions.

@charris
REL: Prepare for the NumPy 1.24.2 release
1242525 
- Create 1.24.2-changelog.rst
- Update 1.24.2-notes.rst
@charris charris force-pushed the prepare-1.24.2-release branch from 77fc6cf to 1242525 Compare February 5, 2023 14:57
@charris charris merged commit 85f38ab into numpy:maintenance/1.24.x Feb 5, 2023
@charris charris deleted the prepare-1.24.2-release branch February 5, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

14 - Release 36 - Build Build related PR

Projects

None yet

Milestone

1.24.2 release

Development

Successfully merging this pull request may close these issues.

2 participants

@charris @mattip