MAINT: Move export for scipy arm64 helper into main module#22939
Merged
mattip merged 1 commit intonumpy:mainfrom Jan 7, 2023
Merged
MAINT: Move export for scipy arm64 helper into main module#22939mattip merged 1 commit intonumpy:mainfrom
mattip merged 1 commit intonumpy:mainfrom
Conversation
Member
Author
|
Actually... I am getting that nextafter issue with the SciPy 1.9.3 wheels also on main, so it fixes that up. |
This is a follow up to numpygh-22679 which addressed numpygh-22673. The main thing is that we want the functions to be available after importing NumPy, so they need to be part of multiarray. However, `npymath` is a static library, so the symbols are not really exported there. The former PR did actually work in practice but this seems like it is technically the right place? For some reason, I had to add nextafter to be able to do: from scipy.spatial.distance import euclidean with the SciPy 1.9.3 wheels. SciPy test collection works with this for the 1.9.3 wheel, so this should be all the symbols hopefully.
2b77db3 to
d0a613c
Compare
Member
|
If I understand correctly, anyone using SciPy 1.9.x from wheels on macos arm64 (which cross-compile and thus do not link correctly to |
Member
|
Thanks @seberg |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up to gh-22679 which addressed gh-22673.
The main thing is that we want the functions to be available after importing NumPy, so they need to be part of multiarray. However,
npymathis a static library, so the symbols are not really exported there. The former PR did actually work in practice but this seems like it is technically the right place?For some reason,I had to add nextafter to be able to do:with the SciPy 1.9.3 wheels. SciPy test collection works with this for the 1.9.3 wheel, so this should be all the symbols hopefully.
@mattip this was what I figured to solve the internal linking warnings that I have been seeing now. Does this make sense to you?
Maybe it also doesn't matter, since we should pull the whole hack out soon enough.