Skip to content

Improve IRI resolution according to RFC3986#260

Merged
ansell merged 3 commits intojsonld-java:masterfrom
fsteeg:232-iri
Jun 26, 2019
Merged

Improve IRI resolution according to RFC3986#260
ansell merged 3 commits intojsonld-java:masterfrom
fsteeg:232-iri

Conversation

@fsteeg
Copy link
Member

@fsteeg fsteeg commented Jun 11, 2019

Adds tests from https://github.com/w3c/json-ld-api and fixes some issues in IRI resolution according to RFC3986 exposed by these tests (4eb40f9). Was triggered by #232, for which I contributed additional tests to https://github.com/w3c/json-ld-api in w3c/json-ld-api#103 (5b48cba). Replaces #258.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 89.27% when pulling fce53a4 on fsteeg:232-iri into 44c1bba on jsonld-java:master.

@dr0i
Copy link
Member

dr0i commented Jun 24, 2019

+1
@ansell can this be merged or do you want to have a closer look?

Copy link
Member

@ansell ansell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some tests that were added to the jsonld.org test manifest that do not appear in the jsonld.org git repository. Ughh, I am not good at reading today. I didn't realise that the testsuite had been moved. My bad

@ansell ansell merged commit 66012db into jsonld-java:master Jun 26, 2019
@ansell ansell added the Bug label Jun 26, 2019
@gkellogg
Copy link

Note that the json-ld.org version of the test suite is obsolete, and the official locations for the test suites are at https://w3c.github.io/json-ld-api/tests/ and https://w3c.github.io/json-ld-framing/tests/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants