feat: support attaching bytes by jpnurmi · Pull Request #1275 · getsentry/sentry-native

jpnurmi · 2025-06-13T13:10:47Z

Q: Should it be called sentry_attach_buffer or sentry_attach_data?
A: sentry_attach_bytes

TODO:

~~Crashpad: IPC~~
- ~~feat: support attaching bytes on Windows and Linux crashpad#127~~ (write files instead due to IPC limits)
Crashpad: filenames must be unique
- feat: ensure unique file names for attachments crashpad#129
Integration tests
Docs
- feat(native): attach bytes sentry-docs#14077
- Consider copying Size Limits and linking from the API docs?

github-actions · 2025-06-13T13:11:13Z

	Messages
📖	Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 8775959

supervacuus · 2025-06-13T13:20:45Z

If we want to stay consistent with other SDKs, bytes is fine since we also use it for the UUID API in a similar manner. data is somewhat unspecific. We use data in the context of user_data for callbacks (but only as parameter specs) and data as the field for transactions and spans (as part of the function names).

> warning C4190: 'to_crashpad_attachment' has C-linkage specified, > but returns UDT 'crashpad::Attachment' which is incompatible with C

src/backends/sentry_backend_crashpad.cpp

type & content_type are passed separately and content_type is cloned in sentry__attachments_add()

include/sentry.h

src/CMakeLists.txt

supervacuus

This looks nice, thanks! A couple of minor points and one thing that is probably just a limit of my imagination.

src/backends/sentry_backend_breakpad.cpp

src/path/sentry_path.cpp

src/sentry_attachment.c

supervacuus

I don't know if you'd still like to add anything, but from my end, this is ready to be released.

jpnurmi · 2025-06-24T13:24:10Z

I don't have anything else in mind regarding attachments. We should now have everything that was requested. Thanks for your time reviewing yet another big PR.

jpnurmi mentioned this pull request Jun 16, 2025

feat: support attaching bytes on Windows and Linux getsentry/crashpad#127

Closed

jpnurmi force-pushed the feat/attach-data-buffer branch from fc2a84c to 90f233b Compare June 17, 2025 07:21

feat: Support attaching bytes

9e3dd5e

jpnurmi force-pushed the feat/attach-data-buffer branch from 90f233b to 9e3dd5e Compare June 17, 2025 07:44

jpnurmi added 15 commits June 17, 2025 09:58

fix: move to_crashpad_attachment out of extern C

ab1f169

> warning C4190: 'to_crashpad_attachment' has C-linkage specified, > but returns UDT 'crashpad::Attachment' which is incompatible with C

fix: lint

69919aa

fix: unreachable

aa58bd0

test: integration

dd50bd6

test: rename

eb8355e

test: attaching bytes to crashpad is supported on win32 and linux

5b3a82c

crashpad: dump byte attachments on disk

07dc9f4

fix: windows

c3e36ef

let crashpad ensure unique file names

59b3db6

fix sentry__attachment_from_buffer

a6ce904

clean up unused uuid

ebc0576

Update external/crashpad

6d14051

alternative: ensure unique file in sentry_backend_crashpad

d4aa6c1

clean up

750bc95

clean up more

5109a1c

jpnurmi commented Jun 18, 2025

View reviewed changes

src/backends/sentry_backend_crashpad.cpp Show resolved Hide resolved

switch to std::filesystem

b07ba9b

jpnurmi mentioned this pull request Jun 18, 2025

feat(native): attach bytes getsentry/sentry-docs#14077

Merged

6 tasks

jpnurmi added 5 commits June 19, 2025 09:14

fix leaks in backends

8bc17bd

add sentry__attachment_from_path for convenience and to reduce diff

5bef73d

fix self-review findings

bb6f8e9

revert accidental ws changes

84ba475

fix attachment_clone

575ac47

type & content_type are passed separately and content_type is cloned in sentry__attachments_add()

jpnurmi changed the title ~~feat: Support attaching in-memory data buffers~~ feat: support attaching bytes Jun 19, 2025

jpnurmi marked this pull request as ready for review June 19, 2025 08:22

jpnurmi requested review from JoshuaMoelans and supervacuus June 19, 2025 08:29

jpnurmi commented Jun 19, 2025

View reviewed changes

include/sentry.h Show resolved Hide resolved

include/sentry.h Show resolved Hide resolved

jpnurmi added 2 commits June 19, 2025 12:16

unit-testable sentry__path_unique() to back the "-N.tar.gz" claims

2411b80

include <string>

a2cbba1

jpnurmi commented Jun 19, 2025

View reviewed changes

src/CMakeLists.txt Outdated Show resolved Hide resolved

supervacuus requested changes Jun 20, 2025

View reviewed changes

src/backends/sentry_backend_breakpad.cpp Outdated Show resolved Hide resolved

src/path/sentry_path.cpp Outdated Show resolved Hide resolved

src/sentry_attachment.c Show resolved Hide resolved

src/sentry_attachment.c Show resolved Hide resolved

jpnurmi added 6 commits June 20, 2025 09:15

ref: unique paths for byte attachments

4062a4c

add note about unique file names with crashpad

434943a

add missing null checks for screenshots

c58b350

attachment_clone: add missing error handling

8ff4a53

add note and missing test for buffer attachment comparison

c3fd383

Bump external/crashpad

dbd674c

jpnurmi mentioned this pull request Jun 22, 2025

feat: ensure unique file names for attachments getsentry/crashpad#129

Merged

jpnurmi added 2 commits June 22, 2025 21:08

Update external/crashpad

b5b13ee

attachment_eq: clarify with a comment

070d933

supervacuus reviewed Jun 24, 2025

View reviewed changes

src/sentry_attachment.c Outdated Show resolved Hide resolved

jpnurmi added 2 commits June 24, 2025 14:27

document behavior regarding duplicate attachments

645cfdd

sentry__attachments_remove: replace attachment_eq with ptr cmp

8775959

supervacuus reviewed Jun 24, 2025

View reviewed changes

src/sentry_attachment.c Show resolved Hide resolved

supervacuus approved these changes Jun 24, 2025

View reviewed changes

jpnurmi merged commit 9dd7d6c into master Jun 24, 2025
55 of 58 checks passed

jpnurmi deleted the feat/attach-data-buffer branch June 24, 2025 14:27

BrewTestBot mentioned this pull request Jun 25, 2025

sentry-native 0.9.1 Homebrew/homebrew-core#228102

Merged

1 task

jpnurmi mentioned this pull request Jun 25, 2025

Changing attachments after sentry_init #586

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: support attaching bytes#1275

feat: support attaching bytes#1275
jpnurmi merged 34 commits intomasterfrom
feat/attach-data-buffer

jpnurmi commented Jun 13, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jun 13, 2025 •

edited

Loading

Uh oh!

supervacuus commented Jun 13, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

supervacuus left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

supervacuus left a comment

Uh oh!

jpnurmi commented Jun 24, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

jpnurmi commented Jun 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jun 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

supervacuus commented Jun 13, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

supervacuus left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

supervacuus left a comment

Choose a reason for hiding this comment

Uh oh!

jpnurmi commented Jun 24, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jpnurmi commented Jun 13, 2025 •

edited

Loading

github-actions bot commented Jun 13, 2025 •

edited

Loading