Skip to content

feat(native): attach bytes#14077

Merged
bruno-garcia merged 2 commits intomasterfrom
feat/native-attach-bytes
Jul 9, 2025
Merged

feat(native): attach bytes#14077
bruno-garcia merged 2 commits intomasterfrom
feat/native-attach-bytes

Conversation

@jpnurmi
Copy link
Copy Markdown
Collaborator

@jpnurmi jpnurmi commented Jun 18, 2025

DESCRIBE YOUR PR

Documentation for attaching bytes using the Native SDK, as introduced by the following PR:

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

@vercel
Copy link
Copy Markdown

vercel bot commented Jun 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2025 1:35pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Visit Preview Jun 20, 2025 1:35pm

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 18, 2025

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.92MB -9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.77MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 873.24kB -0.0%
static/chunks/7750-*.js -3 bytes 401.83kB -0.0%
static/qrL9Tjp2cLWGInOzRoLG6/_buildManifest.js (New) 616 bytes 616 bytes 100.0% 🚀
static/qrL9Tjp2cLWGInOzRoLG6/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/CBec57IKHgqK0Gtj9T6Ub/_buildManifest.js (Deleted) -616 bytes 0 bytes -100.0% 🗑️
static/CBec57IKHgqK0Gtj9T6Ub/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.64MB -0.0%
../instrumentation.js -3 bytes 973.36kB -0.0%
9523.js -3 bytes 949.31kB -0.0%

Copy link
Copy Markdown
Collaborator

@supervacuus supervacuus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps a mention (or even an alert) of the unique filename behavior when using crashpad, as it is the most commonly used backend? Otherwise, LGTM.

@jpnurmi jpnurmi marked this pull request as ready for review June 24, 2025 15:43
@jpnurmi jpnurmi requested a review from bruno-garcia July 9, 2025 05:52
@bruno-garcia bruno-garcia merged commit 00c0bfd into master Jul 9, 2025
12 checks passed
@bruno-garcia bruno-garcia deleted the feat/native-attach-bytes branch July 9, 2025 06:16
@github-actions github-actions bot locked and limited conversation to collaborators Jul 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants