fix: build error introduced by crashpad C++17 support#1118
Merged
supervacuus merged 15 commits intomasterfrom Jan 20, 2025
Merged
fix: build error introduced by crashpad C++17 support#1118supervacuus merged 15 commits intomasterfrom
crashpad C++17 support#1118supervacuus merged 15 commits intomasterfrom
Conversation
3 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1118 +/- ##
==========================================
+ Coverage 82.66% 82.69% +0.03%
==========================================
Files 53 53
Lines 7930 7930
Branches 1240 1240
==========================================
+ Hits 6555 6558 +3
+ Misses 1264 1261 -3
Partials 111 111 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1115
Details: getsentry/mini_chromium#2
Tracking PR crashpad: getsentry/crashpad#117