Skip to content

mini_chromium requres C++20 header span.h #1115

@aokerholm-cobot

Description

@aokerholm-cobot

Description

I am unable to build with C++17 because my system lacks the span.h header file.
There is a reasonable substitute available here:
https://github.com/tcbrindle/span/blob/master/include/tcb/span.hpp
Copying this file to base/numerics/span.hpp and using quotes in base/numerics/byte_conversions.h solves the problem

When does the problem happen

  • During build
  • During run-time
  • When capturing a hard crash

Environment

  • OS: Ubuntu 22.04
  • Compiler: g++ 9.4.0-1ubuntu1~20.04.2
  • CMake version and config: [3.30.2, SENTRY_BACKEND=crashpad]

Steps To Reproduce

cmake --build build --parallel

Log output

In file included from /home/third-party/sentry-native/external/crashpad/util/misc/uuid.cc:31:
/home/third-party/sentry-native/external/crashpad/third_party/mini_chromium/mini_chromium/base/numerics/byte_conversions.h:12:10: fatal error: span: No such file or directory
12 | #include
| ^~~~~~
compilation terminated.
make[2]: *** [crashpad_build/util/CMakeFiles/crashpad_util.dir/build.make:328: crashpad_build/util/CMakeFiles/crashpad_util.dir/misc/uuid.cc.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [CMakeFiles/Makefile2:461: crashpad_build/util/CMakeFiles/crashpad_util.dir/all] Error 2
make: *** [Makefile:146: all] Error 2

Metadata

Metadata

Assignees

Labels

No labels
No labels
No fields configured for issues without a type.

Projects

Status

No status

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions