Skip to content

chore(deps): bump win32 from 2.7.0 to 3.0.0 in /packages/share_plus/share_plus_windows#1214

Merged
vbuberen merged 3 commits into
mainfrom
dependabot/pub/packages/share_plus/share_plus_windows/win32-3.0.0
Oct 12, 2022
Merged

chore(deps): bump win32 from 2.7.0 to 3.0.0 in /packages/share_plus/share_plus_windows#1214
vbuberen merged 3 commits into
mainfrom
dependabot/pub/packages/share_plus/share_plus_windows/win32-3.0.0

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Oct 11, 2022

Copy link
Copy Markdown
Contributor

Bumps win32 from 2.7.0 to 3.0.0.

Changelog

Sourced from win32's changelog.

3.0.0

  • This release includes an overhaul of the COM and WinRT API generation, as described below. Apps and packages that call traditional Win32 APIs should not require changes, but apps that use COM or the highly-experimental WinRT APIs should expect to make changes.
  • [BREAKING CHANGE] WinRT APIs have been moved to a separate library. This provides isolation for apps that only use traditional APIs (Win32/COM) from the more experimental WinRT APIs. To use WinRT from your code, change your import statement to import 'package:win32/winrt.dart';. The WinRT library also exports all Win32 APIs, so you don't have to import both libraries.
  • [BREAKING CHANGE] COM and Windows Runtime methods and properties are now camelCased, not TitleCased. This is inconvenient, but it avoids a whole class of name clashes and aligns COM and WinRT APIs more closely with Dart idioms. As the projections get smarter with more helpers, we think this is the right call for the future and worth a one-time tax to fix.
  • [BREAKING CHANGE] You can now cast to a new COM interface without needing the IID for the target interface. Instead of:
  final modalWindow = IModalWindow(fileDialog.toInterface(IID_IModalWindow));

write:

  final modalWindow = IModalWindow.from(fileDialog);
  • [BREAKING CHANGE] WinRT classes now support projection of Lists and Strings directly.
  • [BREAKING CHANGE] The WinRT fromPointer method is now fromRawPointer.
  • GUIDFromString now supports an optional custom allocator parameter.
  • Added various APIs from iphlpapi.dll for tracking and renewing IP addresses.
  • Added DisableThreadLibraryCalls, FindStringOrdinal, GetConsoleCP, GetConsoleOutputCP, GetModuleHandleExW, GetNumberOfConsoleInputEvents, GetVolumeInformation, GetVolumeInformationByHandle, PeekConsoleInput, ReadConsoleInputW, SetErrorMode, SetThreadErrorMode, SizeofResource APIs from kernel32.dll
  • Added GetClassFile API from ole32.dll
  • Added SetupDiGetDeviceInstanceId, SetupDiGetDeviceRegistryPropertyW APIs from setupapi.dll
  • Added GetAltTabInfoW, GetClassNameW, GetGUIThreadInfo APIs from user32.dll
  • Added various foundational WinRT types, including IIterable, IIterator, IKeyValuePair, IMapView, IVector, IVectorView, IPropertyValue, IReference, with tremendous thanks again to @​halildurmus, who has driven much of the recent WinRT work.
  • Major reworking of the WinRT generation code, thanks to @​halildurmus.
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot
chore(deps): bump win32 in /packages/share_plus/share_plus_windows
aeef445 
Bumps [win32](https://github.com/timsneath/win32) from 2.7.0 to 3.0.0.
- [Release notes](https://github.com/timsneath/win32/releases)
- [Changelog](https://github.com/timsneath/win32/blob/main/CHANGELOG.md)
- [Commits](halildurmus/win32@v2.7.0...v3.0.0)

---
updated-dependencies:
- dependency-name: win32
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added dart Pull requests that update Dart code dependencies Pull requests that update a dependency file labels Oct 11, 2022
@vbuberen

vbuberen commented Oct 12, 2022

Copy link
Copy Markdown
Collaborator

Despite breaking changes I see that tests still pass, so should be safe to merge (unless we have not enough tests 😄 )

vbuberen
vbuberen requested changes Oct 12, 2022
View reviewed changes

@vbuberen vbuberen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However, don't like that there is a range of version instead of specifying 3.0.0

@vbuberen

vbuberen commented Oct 12, 2022

Copy link
Copy Markdown
Collaborator

Ok, it seems that Dependabot made such range to be compatible with filepicker_windows, which is used in example app.

Screenshot 2022-10-12 at 19 50 46

Thus, it makes not much sense to do a range >=2.3.8 <4.0.0 unless we do dependency override or wait till newer filepicker_windows is release.

@vbuberen vbuberen mentioned this pull request Oct 12, 2022
Closed
7 tasks
@alexmercerind

alexmercerind commented Oct 12, 2022

Copy link
Copy Markdown
Contributor

I can remove win32 dependency completely, I think it'd be more flexible.

@alexmercerind

alexmercerind commented Oct 12, 2022

Copy link
Copy Markdown
Contributor

Nevermind, it seems #1223 replaces package:filepicker_windows with package:file_selector which doesn't depend on win32 & is cross-platform. So, failing tests should pass now.

(I couldn't add package:file_selector because it required some iOS specific configuration & I don't have one)

@vbuberen

vbuberen commented Oct 12, 2022

Copy link
Copy Markdown
Collaborator

@dependabot rebase

@dependabot @github

dependabot Bot commented on behalf of github Oct 12, 2022

Copy link
Copy Markdown
Contributor Author

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@vbuberen

vbuberen commented Oct 12, 2022

Copy link
Copy Markdown
Collaborator

Alright, will update the branch myself to get latest changes.

Nevermind, it seems #1223 replaces package:filepicker_windows with package:file_selector which doesn't depend on win32 & is cross-platform. So, failing tests should pass now.

Thanks for pointing. Missed this PR.

@vbuberen vbuberen merged commit 9274de3 into main Oct 12, 2022
@vbuberen vbuberen deleted the dependabot/pub/packages/share_plus/share_plus_windows/win32-3.0.0 branch October 12, 2022 21:04
@miquelbeltran miquelbeltran mentioned this pull request Oct 13, 2022
Closed
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jan 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@vbuberen vbuberen vbuberen approved these changes

Assignees

No one assigned

Labels

dart Pull requests that update Dart code dependencies Pull requests that update a dependency file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vbuberen @alexmercerind