fix(share_plus): Show NSSharingServicePicker asynchronously on main thread#1223
Merged
Conversation
Allow all Desktop platform to use share_plus example
miquelbeltran
approved these changes
Oct 12, 2022
miquelbeltran
left a comment
Member
There was a problem hiding this comment.
LGTM! Thanks for updating the example code as well
Member
|
Just a note, we need clarification if #1177 refers to iOS or macOS (or both) |
Contributor
Author
Only macOS (the change refer to the file |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the MacOS implementation of share_plus show the
NSSharingServicePickerasynchronously.For testing purpose i've update the corresponding sample app :
replace filepicker_windows with file_selector, for a working sample in all desktop (MacOS, Windows, Linux).
Related Issues
Checklist
CHANGELOG.mdnor thepubspec.yamlfiles.flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
!in the title as explained in Conventional Commits).