Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

Thanks I'll have a look soon

Hi @chrisjsewell and @choldgraf,

@sappelhoff suggested at #128 (review) (thanks!):

It's probably a better idea to stick with the #127 PR and make comments there about how it can be tweaked to make "copying empty lines" the default behavior. Otherwise, there will be two nearly identical PRs open which will confuse reviewers and will lead to diverging discussions that are easy to miss.

I will be very happy to add da08b04 to this PR instead of #128, in order to make copying empty lines the default, if both of you agree it would be the right choice.

At #84 (comment), @sappelhoff notes:

I would vote for making copying empty lines the default.

With kind regards,
Andreas.

Hi @chrisjsewell and @choldgraf,

do you also agree that we should make copying empty lines the default behavior? If so, I would add da08b04 on top of f18bd05 here in order to make that happen before a code review.

With kind regards,
Andreas.

Thanks for the ping - yep I agree we should make copying empty lines the default behavior. if there are two PRs doing very similar things it’ll be easier to just discuss in a single PR.

Dear Chris,

thanks for your response. I just added da08b04 to this patchset and closed #128.

With kind regards,
Andreas.

Can you have a look at this, @choldgraf or @chrisjsewell?

hey @amotl - thanks for this update. please be patient, we are all split across many projects and responsibilities :-)

Hi Chris,

Please be patient, we are all split across many projects and responsibilities :-)

Sure, same thing here. I didn't want to come off impatient, apologies!

With kind regards,
Andreas.

This looks great to me - the implementation seems correct, and you've added docs and test cases. I'll give this a merge and we can spot-check updates if needed. Thanks for the improvement 🎉

Congrats on your first merged pull request in this project! 🎉


Thank you for contributing, we are very proud of you! ❤️

Dear @choldgraf,

thanks a stack for merging this patch!

Now, hoping not to come over too impatient again, can I humbly ask one of the maintainers to run a new release cycle? Then, we would be able to integrate this feature back into our documentation (crate/crate-docs-theme#288).

With kind regards,
Andreas.

Maybe we can get #126 merged quickly and then release? If you have any comments on @sappelhoff's PR perhaps that can push things forward, but I think it is quite close

Maybe we can get #126 merged quickly and then release?

Would anything speak against including the two translation PRs #116 #120 in that release?