IMPROVE: Make copying empty lines the default#128
Closed
amotl wants to merge 2 commits intoexecutablebooks:masterfrom
Closed
IMPROVE: Make copying empty lines the default#128amotl wants to merge 2 commits intoexecutablebooks:masterfrom
amotl wants to merge 2 commits intoexecutablebooks:masterfrom
Conversation
ff5c827 to
da08b04
Compare
sappelhoff
reviewed
May 28, 2021
Contributor
sappelhoff
left a comment
There was a problem hiding this comment.
Just a small comment from a non-maintainer following along: It's probably a better idea to stick with the #127 PR and make comments there about how it can be tweaked to make "copying empty lines" the default behavior.
Otherwise there will be two nearly identical PRs open which will confuse reviewers and will lead to diverging discussions that are easy to miss.
(That is, I suggest to close this one and recommend you make your valid point in #127 as comments)
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi again,
this patch builds upon #127 and would enable the new
copybutton_copy_empty_linesoption by default. Do you believe this is reasonable?With kind regards,
Andreas.