Merged
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/52321/ |
This was referenced May 26, 2022
Member
|
@JLHwung Are you writing |
This was referenced May 30, 2022
This was referenced May 31, 2022
packages/babel-types/package.json
Outdated
| "dependencies": { | ||
| "@babel/helper-validator-identifier": "workspace:^", | ||
| "to-fast-properties": "^2.0.0" | ||
| "to-fast-properties": "condition:BABEL_8_BREAKING ? ^4.0.0 : ^2.0.0" |
Member
There was a problem hiding this comment.
v4 is native ESM, that we can't use yet because we compile to CJS. We should downgrade to v3.
Contributor
Author
There was a problem hiding this comment.
🤔 Aren't we gonna make Babel 8 ESM-only?
Member
There was a problem hiding this comment.
Yes, but it's not ready yet so the current Babel 8 build fails with this PR 😛
We will be able to upgrade before Babel 8.0.0, but not yet.
bceef21 to
18291cb
Compare
* preset-typescript * transform-typescript * Update packages/babel-plugin-transform-typescript/src/enum.ts Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com> * prettier Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
* enable noImplicitAny * codemod (#14602) * Improve preset/plugin-typescript typings (#14603) * preset-typescript * transform-typescript * Update packages/babel-plugin-transform-typescript/src/enum.ts Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com> * prettier Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com> * improve transform-runtime typings Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
* improve helper-function-name typings * helper hoist variables * helper-member-expression-to-functions * helper-simple-access * remap-async-to-generator * helper-annotate-as-pure * helper-builder-binary-assignment-operator-visitor * helper-check-duplicate-nodes * early return when export declaration is export all * split-export-declaration * helper-define-map * define-map * Update packages/babel-helper-builder-binary-assignment-operator-visitor/src/index.ts Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com> * review comments Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
* refactor: simplify ImportInjector._applyDefaults * helper-module-imports * map globals to the one used in Babel 8
* plugin-test-runner * fixture-test-runner * Update packages/babel-helper-fixtures/src/index.ts Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com> Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
* refactor: move shipped-proposals to ts * preset-env * address review comments
* refactor: simplify buildOptimizedSequenceExpression * proposal-pipeline-operator * address review comments
* babel-standalone * address review comment
* change AssumptionFunction return type * helper-create-regexp-features-plugin * create-class-features-plugin * transform-for-of * improve unicode-escapes typings * transform-object-super * transform-react-constant-elements * proto-to-assign * function-name * flow-comments TS cannot infer Flow visitor type because we have both Flow type and Flow virtual type.
* code-frame * map js-tokens to Babel 8 * highlight
Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
* generator
* refactor: merge {start,end}Terminatorless to printTerminatorless
* inline buildYieldAwait
* inline ExportDeclaration
* also export Pos
* let getPossibleRaw return string | void
* Apply suggestions from code review
Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
Co-authored-by: liuxingbaoyu <30521560+liuxingbaoyu@users.noreply.github.com>
* address review comments
* do not export internal printer method
* simplify needsWhitespace
Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
Co-authored-by: liuxingbaoyu <30521560+liuxingbaoyu@users.noreply.github.com>
* exponentiation-operator * duplicate-keys * computed-properties * replace-supers * block-scoping * block-scoped-functions * syntax-typescript * record-and-tuple * private-property-in-object * partial-application * json-strings * function-sent * function-bind * class-static-block * async-generator-functions * Update packages/babel-plugin-transform-block-scoping/src/index.ts * address review comments * helper-replace-supers
* external-helpers * bugfix * transform-parameters * object-rest-spread * destructuring-private * transform-destructuring * proposal-decorators * optional-chaining * helper-wrap-function * explode-assignable-expression * helper-compilation-targets * helper-plugin-utils * helpers * helper-validator-option * fix: allow "+" and "-" in MappedType .readonly/.optional * fixture-test-runner * remove charcodes from dependencies the charcodes transform will inline charCodes.* so we can remove it from dependencies
* export removeProperties options * traverse * fix other packages typings * fix gatherNodeParts * downgrade to-fast-properties to v3 * fix typo * babel-core/normalize-file * add ignore comment property used by flow plugin * refine getLastStatement typings * fix babel-standalone rebase typing error * fix assert.rejects polyfill * simplify _param typings * supress Babel 7 AST errors * loosen defineType typings The AST typings are generated from defineType calls, so defineType should accept a string as type. * restore legacy code * Suppress data/core-js-compat importing errors
liuxingbaoyu
approved these changes
Jun 21, 2022
nicolo-ribaudo
approved these changes
Jun 21, 2022
Member
nicolo-ribaudo
left a comment
There was a problem hiding this comment.
Disclaimer: I only reviewed this quickly, but I already reviewed all the commits in their PRs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a meta PR tracking the progress of the
noImplicitAnyoption adoption. I will mark the PR as ready when CI is green.