Skip to content

Update to Yarn 3.1#13856

Merged
nicolo-ribaudo merged 6 commits intobabel:mainfrom
nicolo-ribaudo:yarn-3.1
Oct 24, 2021
Merged

Update to Yarn 3.1#13856
nicolo-ribaudo merged 6 commits intobabel:mainfrom
nicolo-ribaudo:yarn-3.1

Conversation

@nicolo-ribaudo
Copy link
Copy Markdown
Member

@nicolo-ribaudo nicolo-ribaudo commented Oct 17, 2021 •
edited
Loading

Q                       A
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link dev
Any Dependency Changes?
License MIT

This is mostly to test that Yarn 3.1.0 doesn't break us, before that it's released as stable. The first commit is #13858.

The constraints plugin has a breaking change: yarnpkg/berry#3584

@nicolo-ribaudo nicolo-ribaudo added the PR: Internal 🏠 A type of pull request used for our changelog categories label Oct 17, 2021
@nicolo-ribaudo nicolo-ribaudo changed the title Update to Yarn 3.1.0-rc.10 Update to Yarn 3.1 Oct 17, 2021
@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci bot commented Oct 17, 2021 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ccea12e:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@babel-bot
Copy link
Copy Markdown
Collaborator

babel-bot commented Oct 17, 2021 •
edited
Loading

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/49331/

@nicolo-ribaudo nicolo-ribaudo marked this pull request as draft October 17, 2021 14:46
@nicolo-ribaudo nicolo-ribaudo mentioned this pull request Oct 17, 2021
Merged
@nicolo-ribaudo nicolo-ribaudo force-pushed the yarn-3.1 branch 3 times, most recently from a60919b to eede874 Compare October 18, 2021 22:34
@nicolo-ribaudo
Copy link
Copy Markdown
Member Author

nicolo-ribaudo commented Oct 22, 2021

Even if Yarn 3.1 is not stable yet, I'd like to merge this as soon as yarnpkg/berry#3610 is merged because Yarn 3.0 doesn't work on Node.js 17 (#13866 (comment))

@nicolo-ribaudo nicolo-ribaudo mentioned this pull request Oct 22, 2021
Closed
@nicolo-ribaudo
Copy link
Copy Markdown
Member Author

nicolo-ribaudo commented Oct 22, 2021

I don't see how the failure in https://app.circleci.com/pipelines/github/babel/babel/8286/workflows/96713762-dd27-4c39-9142-3fd3e490017c/jobs/49330 could be related (and it's consistent - I restarted it 3 times), but lets see if the last commit fixes it.

@nicolo-ribaudo nicolo-ribaudo marked this pull request as ready for review October 22, 2021 20:30
@nicolo-ribaudo
Copy link
Copy Markdown
Member Author

nicolo-ribaudo commented Oct 22, 2021

The other CI e2e failures on CircleCI are caused by libraries not supporting Node.js 17 yet - they are not related to this PR.

@nicolo-ribaudo nicolo-ribaudo merged commit f2b3134 into babel:main Oct 24, 2021
@nicolo-ribaudo nicolo-ribaudo deleted the yarn-3.1 branch October 24, 2021 12:47
@nicolo-ribaudo
Copy link
Copy Markdown
Member Author

nicolo-ribaudo commented Oct 24, 2021

I'm marking this as "Fixes failing main" even if some e2e tests still fail (because CRA and vue-cli don't support Node.js 17), because it fixes the babel-standalone build.

@snyk-bot snyk-bot mentioned this pull request Dec 14, 2021
Closed
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jan 24, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JLHwung JLHwung JLHwung approved these changes

Assignees

No one assigned

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Fixes failing main PR: Internal 🏠 A type of pull request used for our changelog categories

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nicolo-ribaudo @babel-bot @JLHwung