Skip to content

fix(common): Update Location to get a normalized URL valid in case a represented URL starts with the substring equals APP_BASE_HREF#48489

Closed
constantant wants to merge 1 commit intoangular:mainfrom
constantant:fix-common/45744
Closed

fix(common): Update Location to get a normalized URL valid in case a represented URL starts with the substring equals APP_BASE_HREF#48489
constantant wants to merge 1 commit intoangular:mainfrom
constantant:fix-common/45744

Conversation

@constantant
Copy link
Contributor

@constantant constantant commented Dec 14, 2022

fix(common): Update Location to get a normalized URL valid in case a represented URL starts with the substring equals APP_BASE_HREF

@NgModule({
  imports: [RouterModule.forRoot([{path: '/enigma', component: EnigmaComponent}])],
  providers: [{provide: APP_BASE_HREF, useValue: '/en'}]
})
export class AppModule {}

Navigating to /enigma will redirect to /en/igma not to /en/enigma as it expects

Fixes: #45744

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: 45744

Does this PR introduce a breaking change?

  • Yes
  • No

@pullapprove pullapprove bot requested a review from alxhub December 14, 2022 17:31
@constantant constantant mentioned this pull request Dec 14, 2022
Closed
11 tasks
@jessicajaniuk jessicajaniuk added the area: common Issues related to APIs in the @angular/common package label Dec 14, 2022
@ngbot ngbot bot added this to the Backlog milestone Dec 14, 2022
@jessicajaniuk jessicajaniuk added target: patch This PR is targeted for the next patch release action: review The PR is still awaiting reviews from at least one requested reviewer action: presubmit The PR is in need of a google3 presubmit action: global presubmit The PR is in need of a google3 global presubmit labels Dec 14, 2022
@jessicajaniuk
Copy link
Contributor

jessicajaniuk commented Dec 14, 2022

G3 test failures are unrelated, but we'll need a TGP to be safe.

@constantant
Copy link
Contributor Author

constantant commented Dec 21, 2022

@atscott could you check the PR?

@alan-agius4 alan-agius4 requested a review from atscott January 10, 2023 11:03
@atscott atscott removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Jan 10, 2023
@constantant
fix(common): Update Location to get a normalized URL valid in case …
5c3e4d6 
…a represented URL starts with the substring equals `APP_BASE_HREF`

```ts
@NgModule({
  imports: [RouterModule.forRoot([{path: '/enigma', component: EnigmaComponent}])],
  providers: [{provide: APP_BASE_HREF, useValue: '/en'}]
})
export class AppModule {}
```

Navigating to `/enigma` will redirect to `/en/igma` not to `/en/enigma` as it expects

Fixes: angular#45744
@atscott
Copy link
Contributor

atscott commented Jan 10, 2023

TGP came back green. Running 1 more sanity check after the rebase.

@atscott atscott removed the request for review from alxhub January 11, 2023 16:41
@atscott atscott added action: merge The PR is ready for merge by the caretaker and removed action: presubmit The PR is in need of a google3 presubmit action: global presubmit The PR is in need of a google3 global presubmit labels Jan 11, 2023
@AndrewKushnir
Copy link
Contributor

AndrewKushnir commented Jan 12, 2023

This PR was merged into the repository by commit 8802b4a.

AndrewKushnir pushed a commit that referenced this pull request Jan 12, 2023
@constantant @AndrewKushnir
fix(common): Update Location to get a normalized URL valid in case …
68ce4f6 
…a represented URL starts with the substring equals `APP_BASE_HREF` (#48489)

```ts
@NgModule({
  imports: [RouterModule.forRoot([{path: '/enigma', component: EnigmaComponent}])],
  providers: [{provide: APP_BASE_HREF, useValue: '/en'}]
})
export class AppModule {}
```

Navigating to `/enigma` will redirect to `/en/igma` not to `/en/enigma` as it expects

Fixes: #45744

PR Close #48489
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request Jan 19, 2023
Update angular monorepo to v15.1.1 (#1739)
eab2242 
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@angular/animations](https://github.com/angular/angular) | dependencies | patch | [`15.1.0` -> `15.1.1`](https://renovatebot.com/diffs/npm/@angular%2fanimations/15.1.0/15.1.1) |
| [@angular/common](https://github.com/angular/angular) | dependencies | patch | [`15.1.0` -> `15.1.1`](https://renovatebot.com/diffs/npm/@angular%2fcommon/15.1.0/15.1.1) |
| [@angular/compiler](https://github.com/angular/angular) | dependencies | patch | [`15.1.0` -> `15.1.1`](https://renovatebot.com/diffs/npm/@angular%2fcompiler/15.1.0/15.1.1) |
| [@angular/compiler-cli](https://github.com/angular/angular/tree/main/packages/compiler-cli) ([source](https://github.com/angular/angular)) | devDependencies | patch | [`15.1.0` -> `15.1.1`](https://renovatebot.com/diffs/npm/@angular%2fcompiler-cli/15.1.0/15.1.1) |
| [@angular/core](https://github.com/angular/angular) | dependencies | patch | [`15.1.0` -> `15.1.1`](https://renovatebot.com/diffs/npm/@angular%2fcore/15.1.0/15.1.1) |
| [@angular/forms](https://github.com/angular/angular) | dependencies | patch | [`15.1.0` -> `15.1.1`](https://renovatebot.com/diffs/npm/@angular%2fforms/15.1.0/15.1.1) |
| [@angular/platform-browser](https://github.com/angular/angular) | dependencies | patch | [`15.1.0` -> `15.1.1`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser/15.1.0/15.1.1) |
| [@angular/platform-browser-dynamic](https://github.com/angular/angular) | dependencies | patch | [`15.1.0` -> `15.1.1`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser-dynamic/15.1.0/15.1.1) |

---

### Release Notes

<details>
<summary>angular/angular</summary>

### [`v15.1.1`](https://github.com/angular/angular/blob/HEAD/CHANGELOG.md#&#8203;1511-2023-01-18)

[Compare Source](angular/angular@15.1.0...15.1.1)

##### common

| Commit | Type | Description |
| -- | -- | -- |
| [68ce4f6ab4](angular/angular@68ce4f6) | fix | Update `Location` to get a normalized URL valid in case a represented URL starts with the substring equals `APP_BASE_HREF` ([#&#8203;48489](angular/angular#48489)) |
| [032b2bd689](angular/angular@032b2bd) | perf | avoid excessive DOM mutation in NgClass ([#&#8203;48433](angular/angular#48433)) |

##### core

| Commit | Type | Description |
| -- | -- | -- |
| [dd54f6bd96](angular/angular@dd54f6b) | fix | makeEnvironmentProviders should accept EnvironmentProviders ([#&#8203;48720](angular/angular#48720)) |

#### Special Thanks

Alan Agius, Alex Rickabaugh, Andrew Scott, Aristeidis Bampakos, Bob Watson, Jens, Konstantin Kharitonov, Kristiyan Kostadinov, Matthieu Riegler, Paul Gschwendtner, Pawel Kozlowski, Vladyslav Slipchenko, ced, dario-piotrowicz, mgechev and ノウラ

<!-- CHANGELOG SPLIT MARKER -->

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMDUuMyIsInVwZGF0ZWRJblZlciI6IjM0LjEwNS41In0=-->

Co-authored-by: cabr2-bot <cabr2.help@gmail.com>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1739
Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org>
Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
trekladyone pushed a commit to trekladyone/angular that referenced this pull request Feb 1, 2023
@constantant @trekladyone
fix(common): Update Location to get a normalized URL valid in case …
58b2290 
…a represented URL starts with the substring equals `APP_BASE_HREF` (angular#48489)

```ts
@NgModule({
  imports: [RouterModule.forRoot([{path: '/enigma', component: EnigmaComponent}])],
  providers: [{provide: APP_BASE_HREF, useValue: '/en'}]
})
export class AppModule {}
```

Navigating to `/enigma` will redirect to `/en/igma` not to `/en/enigma` as it expects

Fixes: angular#45744

PR Close angular#48489
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Feb 12, 2023

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@atscott atscott atscott approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: common Issues related to APIs in the @angular/common package target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

APP_BASE_HREF doesn't work with routes which starts with the same text part

4 participants

@constantant @jessicajaniuk @atscott @AndrewKushnir