perf(platform-browser): resolve memory leak when using animations with shadow DOM#47903
Closed
crisbeto wants to merge 1 commit intoangular:mainfrom
Closed
perf(platform-browser): resolve memory leak when using animations with shadow DOM#47903crisbeto wants to merge 1 commit intoangular:mainfrom
crisbeto wants to merge 1 commit intoangular:mainfrom
Conversation
…h shadow DOM `AnimationRendererFactory` maintains a map between a renderer delegate and the animations renderer it corresponds to, but the renderers are never removed from the map. This leads to memory leaks when used with the `ShadowDom` view encapsulation, because the specific renderer keeps a references to its shadow root which in turn references all the elements in the view. These changes resolve the leak by clearing the reference when the animations renderer is destroyed. Fixes angular#47892.
ac6f772 to
9ecada4
Compare
crisbeto
commented
Oct 28, 2022
AndrewKushnir
approved these changes
Oct 29, 2022
Member
|
This PR was merged into the repository by commit 925dd73. |
alxhub
pushed a commit
that referenced
this pull request
Nov 1, 2022
…h shadow DOM (#47903) `AnimationRendererFactory` maintains a map between a renderer delegate and the animations renderer it corresponds to, but the renderers are never removed from the map. This leads to memory leaks when used with the `ShadowDom` view encapsulation, because the specific renderer keeps a references to its shadow root which in turn references all the elements in the view. These changes resolve the leak by clearing the reference when the animations renderer is destroyed. Fixes #47892. PR Close #47903
alxhub
pushed a commit
that referenced
this pull request
Nov 1, 2022
…h shadow DOM (#47903) `AnimationRendererFactory` maintains a map between a renderer delegate and the animations renderer it corresponds to, but the renderers are never removed from the map. This leads to memory leaks when used with the `ShadowDom` view encapsulation, because the specific renderer keeps a references to its shadow root which in turn references all the elements in the view. These changes resolve the leak by clearing the reference when the animations renderer is destroyed. Fixes #47892. PR Close #47903
crapStone
pushed a commit
to Calciumdibromid/CaBr2
that referenced
this pull request
Nov 4, 2022
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/animations](https://github.com/angular/angular) | dependencies | patch | [`14.2.8` -> `14.2.9`](https://renovatebot.com/diffs/npm/@angular%2fanimations/14.2.8/14.2.9) | | [@angular/common](https://github.com/angular/angular) | dependencies | patch | [`14.2.8` -> `14.2.9`](https://renovatebot.com/diffs/npm/@angular%2fcommon/14.2.8/14.2.9) | | [@angular/compiler](https://github.com/angular/angular) | dependencies | patch | [`14.2.8` -> `14.2.9`](https://renovatebot.com/diffs/npm/@angular%2fcompiler/14.2.8/14.2.9) | | [@angular/compiler-cli](https://github.com/angular/angular/tree/main/packages/compiler-cli) ([source](https://github.com/angular/angular)) | devDependencies | patch | [`14.2.8` -> `14.2.9`](https://renovatebot.com/diffs/npm/@angular%2fcompiler-cli/14.2.8/14.2.9) | | [@angular/core](https://github.com/angular/angular) | dependencies | patch | [`14.2.8` -> `14.2.9`](https://renovatebot.com/diffs/npm/@angular%2fcore/14.2.8/14.2.9) | | [@angular/forms](https://github.com/angular/angular) | dependencies | patch | [`14.2.8` -> `14.2.9`](https://renovatebot.com/diffs/npm/@angular%2fforms/14.2.8/14.2.9) | | [@angular/platform-browser](https://github.com/angular/angular) | dependencies | patch | [`14.2.8` -> `14.2.9`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser/14.2.8/14.2.9) | | [@angular/platform-browser-dynamic](https://github.com/angular/angular) | dependencies | patch | [`14.2.8` -> `14.2.9`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser-dynamic/14.2.8/14.2.9) | --- ### Release Notes <details> <summary>angular/angular</summary> ### [`v14.2.9`](https://github.com/angular/angular/blob/HEAD/CHANGELOG.md#​1429-2022-11-03) [Compare Source](angular/angular@14.2.8...14.2.9) ##### platform-browser | Commit | Type | Description | | -- | -- | -- | | [92d28bdd99](angular/angular@92d28bd) | perf | resolve memory leak when using animations with shadow DOM ([#​47903](angular/angular#47903)) | ##### platform-server | Commit | Type | Description | | -- | -- | -- | | [d2d9bbf5ce](angular/angular@d2d9bbf) | fix | call `onSerialize` when state is empty ([#​47888](angular/angular#47888)) | #### Special Thanks Alan Agius, Kristiyan Kostadinov, Virginia Dooley and mgechev <!-- CHANGELOG SPLIT MARKER --> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMy4yIiwidXBkYXRlZEluVmVyIjoiMzQuMTcuMSJ9--> Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1626 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
trekladyone
pushed a commit
to trekladyone/angular
that referenced
this pull request
Feb 1, 2023
…h shadow DOM (angular#47903) `AnimationRendererFactory` maintains a map between a renderer delegate and the animations renderer it corresponds to, but the renderers are never removed from the map. This leads to memory leaks when used with the `ShadowDom` view encapsulation, because the specific renderer keeps a references to its shadow root which in turn references all the elements in the view. These changes resolve the leak by clearing the reference when the animations renderer is destroyed. Fixes angular#47892. PR Close angular#47903
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AnimationRendererFactorymaintains a map between a renderer delegate and the animations renderer it corresponds to, but the renderers are never removed from the map. This leads to memory leaks when used with theShadowDomview encapsulation, because the specific renderer keeps a references to its shadow root which in turn references all the elements in the view.These changes resolve the leak by clearing the reference when the animations renderer is destroyed.
Fixes #47892.