Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: angular/angular
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 14.2.8
Choose a base ref
...
head repository: angular/angular
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 14.2.9
Choose a head ref
  • 6 commits
  • 10 files changed
  • 5 contributors

Commits on Oct 28, 2022

  1. fix(platform-server): call onSerialize when state is empty (#47888)

    Commit a0b2d36#diff-3975e0ee5aa3e06ecbcd76f5fa5134612f7fd2e6802ca7d370973bd410aab55cR25-R31 changed the serialization phase logic so
    that when the state is empty the script tag is not added to the document. As a side effect, this caused the `toJson` not called which caused the `onSerialize` callbacks also not to be called.
    These callbacks are used to provide the value for a key when `toJson` is called. Example: ngrx/platform#101 (comment)
    
    Closes #47172
    
    PR Close #47888
    alan-agius4 authored and alxhub committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    d2d9bbf View commit details
    Browse the repository at this point in the history
  2. docs: improve grammer in CLI command template (#47891)

    Before
    ```
    This command has the following commands:
    ```
    
    Now
    ```
    This command has the following sub-commands:
    ```
    
    PR Close #47891
    alan-agius4 authored and alxhub committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    a5e1104 View commit details
    Browse the repository at this point in the history
  3. docs: Linting corrections. Restructuring or rewording sentences to be…

    … shorter and clearer. (#47897)
    
    PR Close #47897
    trekladyone authored and alxhub committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    65a3338 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2022

  1. perf(platform-browser): resolve memory leak when using animations wit…

    …h shadow DOM (#47903)
    
    `AnimationRendererFactory` maintains a map between a renderer delegate and the animations renderer it corresponds to, but the renderers are never removed from the map. This leads to memory leaks when used with the `ShadowDom` view encapsulation, because the specific renderer keeps a references to its shadow root which in turn references all the elements in the view.
    
    These changes resolve the leak by clearing the reference when the animations renderer is destroyed.
    
    Fixes #47892.
    
    PR Close #47903
    crisbeto authored and alxhub committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    92d28bd View commit details
    Browse the repository at this point in the history
  2. docs: update roadmap as of q4 2022 (#47910)

    PR Close #47910
    mgechev authored and alxhub committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    f7f354a View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2022

  1. Configuration menu
    Copy the full SHA
    bab5f9a View commit details
    Browse the repository at this point in the history
Loading