[14.2 backport] perf(compiler-cli): cache source file for reporting type-checking dia…#47508
Closed
JoostK wants to merge 1 commit intoangular:14.2.xfrom
Closed
[14.2 backport] perf(compiler-cli): cache source file for reporting type-checking dia…#47508JoostK wants to merge 1 commit intoangular:14.2.xfrom
JoostK wants to merge 1 commit intoangular:14.2.xfrom
Conversation
…gnostics When reporting type-checking diagnostics in external templates we create a `ts.SourceFile` of the template text, as this is needed to report Angular template diagnostics using TypeScript's diagnostics infrastructure. Each reported diagnostic would create its own `ts.SourceFile`, resulting in repeatedly parsing of the template text and potentially high memory usage if the template is large and there are many diagnostics reported. This commit caches the parsed template in the template mapping, such that all reported diagnostics get to reuse the same `ts.SourceFile`. Closes angular#47470
f7a9f71 to
3e5f9ea
Compare
Member
Author
|
merge-assistance: this is a patch backport — no presubmit needed and has already been approved in #47471. |
Member
|
This PR was merged into the repository by commit a4b66fe. |
alxhub
pushed a commit
that referenced
this pull request
Sep 28, 2022
…gnostics (#47508) When reporting type-checking diagnostics in external templates we create a `ts.SourceFile` of the template text, as this is needed to report Angular template diagnostics using TypeScript's diagnostics infrastructure. Each reported diagnostic would create its own `ts.SourceFile`, resulting in repeatedly parsing of the template text and potentially high memory usage if the template is large and there are many diagnostics reported. This commit caches the parsed template in the template mapping, such that all reported diagnostics get to reuse the same `ts.SourceFile`. Closes #47470 PR Close #47508
crapStone
pushed a commit
to Calciumdibromid/CaBr2
that referenced
this pull request
Oct 5, 2022
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/animations](https://github.com/angular/angular) | dependencies | patch | [`14.2.3` -> `14.2.4`](https://renovatebot.com/diffs/npm/@angular%2fanimations/14.2.3/14.2.4) | | [@angular/common](https://github.com/angular/angular) | dependencies | patch | [`14.2.3` -> `14.2.4`](https://renovatebot.com/diffs/npm/@angular%2fcommon/14.2.3/14.2.4) | | [@angular/compiler](https://github.com/angular/angular) | dependencies | patch | [`14.2.3` -> `14.2.4`](https://renovatebot.com/diffs/npm/@angular%2fcompiler/14.2.3/14.2.4) | | [@angular/compiler-cli](https://github.com/angular/angular/tree/main/packages/compiler-cli) ([source](https://github.com/angular/angular)) | devDependencies | patch | [`14.2.3` -> `14.2.4`](https://renovatebot.com/diffs/npm/@angular%2fcompiler-cli/14.2.3/14.2.4) | | [@angular/core](https://github.com/angular/angular) | dependencies | patch | [`14.2.3` -> `14.2.4`](https://renovatebot.com/diffs/npm/@angular%2fcore/14.2.3/14.2.4) | | [@angular/forms](https://github.com/angular/angular) | dependencies | patch | [`14.2.3` -> `14.2.4`](https://renovatebot.com/diffs/npm/@angular%2fforms/14.2.3/14.2.4) | | [@angular/platform-browser](https://github.com/angular/angular) | dependencies | patch | [`14.2.3` -> `14.2.4`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser/14.2.3/14.2.4) | | [@angular/platform-browser-dynamic](https://github.com/angular/angular) | dependencies | patch | [`14.2.3` -> `14.2.4`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser-dynamic/14.2.3/14.2.4) | --- ### Release Notes <details> <summary>angular/angular</summary> ### [`v14.2.4`](https://github.com/angular/angular/blob/HEAD/CHANGELOG.md#​1424-2022-09-28) [Compare Source](angular/angular@14.2.3...14.2.4) ##### compiler-cli | Commit | Type | Description | | -- | -- | -- | | [a4b66fe1e5](angular/angular@a4b66fe) | perf | cache source file for reporting type-checking diagnostics ([#​47508](angular/angular#47508)) | ##### core | Commit | Type | Description | | -- | -- | -- | | [2c46b5ab24](angular/angular@2c46b5a) | fix | correctly check for `typeof` of undefined in `ngDevMode` check ([#​47480](angular/angular#47480)) | #### Special Thanks Alan Agius, Ashley Hunter, Doug Parker, Jessica Janiuk, JoostK, Kristiyan Kostadinov, Rokas Brazdžionis and Simona Cotin <!-- CHANGELOG SPLIT MARKER --> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMDguMCIsInVwZGF0ZWRJblZlciI6IjMyLjIwOC4wIn0=--> Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1569 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…gnostics
When reporting type-checking diagnostics in external templates we create a
ts.SourceFileof the template text, as this is needed to report Angular template diagnostics using TypeScript's diagnostics infrastructure. Each reported diagnostic would create its ownts.SourceFile, resulting in repeatedly parsing of the template text and potentially high memory usage if the template is large and there are many diagnostics reported. This commit caches the parsed template in the template mapping, such that all reported diagnostics get to reuse the samets.SourceFile.Closes #47470
Backport of #47471