fix(core): correctly check for typeof of undefined in ngDevMode check (#47480)

alan-agius4 · alxhub · commit 2c46b5ab24e2 · 2022-09-23T14:00:46.000-07:00
Previously, this check was wrong as typeof returns a string. PR Close #47480
diff --git a/packages/core/src/util/is_dev_mode.ts b/packages/core/src/util/is_dev_mode.ts
@@ -49,7 +49,7 @@ export function enableProdMode(): void {
 
   // The below check is there so when ngDevMode is set via terser
   // `global['ngDevMode'] = false;` is also dropped.
-  if (typeof ngDevMode === undefined || !!ngDevMode) {
+  if (typeof ngDevMode === 'undefined' || ngDevMode) {
     global['ngDevMode'] = false;
   }
 

Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,7 @@ export function enableProdMode(): void {`
`49`	`49`
`50`	`50`	`// The below check is there so when ngDevMode is set via terser`
`51`	`51`	// `global['ngDevMode'] = false;` is also dropped.
`52`		`- if (typeof ngDevMode === undefined \|\| !!ngDevMode) {`
	`52`	`+ if (typeof ngDevMode === 'undefined' \|\| ngDevMode) {`
`53`	`53`	`global['ngDevMode'] = false;`
`54`	`54`	`}`
`55`	`55`