Skip to content

fix(animations): make sure that the useAnimation function delay is applied#47468

Closed
dario-piotrowicz wants to merge 1 commit intoangular:mainfrom
dario-piotrowicz:useAnimation-delay
Closed

fix(animations): make sure that the useAnimation function delay is applied#47468
dario-piotrowicz wants to merge 1 commit intoangular:mainfrom
dario-piotrowicz:useAnimation-delay

Conversation

@dario-piotrowicz
Copy link
Contributor

make sure that when an animation is used via the useAnimation function and a delay has been provided then that delay gets correctly applied

(this PR is a follow up for #47285)

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

If the user provides a delay via useAnimation such delay is ignored:
before

What is the new behavior?

The delay is correctly applied:
after

Does this PR introduce a breaking change?

  • Yes
  • No

…plied

make sure that when an animation is used via the `useAnimation` function
and a delay has been provided then that delay gets correctly applied

(this PR is a follow up for angular#47285)
@pullapprove pullapprove bot requested a review from jessicajaniuk September 17, 2022 15:44
@ngbot ngbot bot added this to the Backlog milestone Sep 19, 2022
@pkozlowski-opensource pkozlowski-opensource added the action: review The PR is still awaiting reviews from at least one requested reviewer label Sep 19, 2022
Copy link
Contributor

@jessicajaniuk jessicajaniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍪

@jessicajaniuk jessicajaniuk added target: patch This PR is targeted for the next patch release action: presubmit The PR is in need of a google3 presubmit action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer action: presubmit The PR is in need of a google3 presubmit labels Sep 19, 2022
@pkozlowski-opensource
Copy link
Member

This PR was merged into the repository by commit d11b1d9.

pkozlowski-opensource pushed a commit that referenced this pull request Sep 20, 2022
…plied (#47468)

make sure that when an animation is used via the `useAnimation` function
and a delay has been provided then that delay gets correctly applied

(this PR is a follow up for #47285)

PR Close #47468
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request Sep 27, 2022
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@angular/animations](https://github.com/angular/angular) | dependencies | patch | [`14.2.2` -> `14.2.3`](https://renovatebot.com/diffs/npm/@angular%2fanimations/14.2.2/14.2.3) |
| [@angular/common](https://github.com/angular/angular) | dependencies | patch | [`14.2.2` -> `14.2.3`](https://renovatebot.com/diffs/npm/@angular%2fcommon/14.2.2/14.2.3) |
| [@angular/compiler](https://github.com/angular/angular) | dependencies | patch | [`14.2.2` -> `14.2.3`](https://renovatebot.com/diffs/npm/@angular%2fcompiler/14.2.2/14.2.3) |
| [@angular/compiler-cli](https://github.com/angular/angular/tree/main/packages/compiler-cli) ([source](https://github.com/angular/angular)) | devDependencies | patch | [`14.2.2` -> `14.2.3`](https://renovatebot.com/diffs/npm/@angular%2fcompiler-cli/14.2.2/14.2.3) |
| [@angular/core](https://github.com/angular/angular) | dependencies | patch | [`14.2.2` -> `14.2.3`](https://renovatebot.com/diffs/npm/@angular%2fcore/14.2.2/14.2.3) |
| [@angular/forms](https://github.com/angular/angular) | dependencies | patch | [`14.2.2` -> `14.2.3`](https://renovatebot.com/diffs/npm/@angular%2fforms/14.2.2/14.2.3) |
| [@angular/platform-browser](https://github.com/angular/angular) | dependencies | patch | [`14.2.2` -> `14.2.3`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser/14.2.2/14.2.3) |
| [@angular/platform-browser-dynamic](https://github.com/angular/angular) | dependencies | patch | [`14.2.2` -> `14.2.3`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser-dynamic/14.2.2/14.2.3) |

---

### Release Notes

<details>
<summary>angular/angular</summary>

### [`v14.2.3`](https://github.com/angular/angular/blob/HEAD/CHANGELOG.md#&#8203;1423-2022-09-21)

[Compare Source](angular/angular@14.2.2...14.2.3)

##### animations

| Commit | Type | Description |
| -- | -- | -- |
| [bba2dae812](angular/angular@bba2dae) | fix | make sure that the useAnimation function delay is applied ([#&#8203;47468](angular/angular#47468)) |

#### Special Thanks

AleksanderBodurri, Andrew Kushnir, Andrew Scott, Bob Watson, George Kalpakas, Joey Perrott, Mauro Mattos, dario-piotrowicz, fabioemoutinho and famzila

<!-- CHANGELOG SPLIT MARKER -->

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMDEuMSIsInVwZGF0ZWRJblZlciI6IjMyLjIwMi4zIn0=-->

Co-authored-by: cabr2-bot <cabr2.help@gmail.com>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1557
Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org>
Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: animations target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants