Skip to content

fix(localize): add --project option to ng-add schematic#46664

Closed
alan-agius4 wants to merge 2 commits intoangular:mainfrom
alan-agius4:name-project-localize
Closed

fix(localize): add --project option to ng-add schematic#46664
alan-agius4 wants to merge 2 commits intoangular:mainfrom
alan-agius4:name-project-localize

Conversation

@alan-agius4
Copy link
Contributor

--project is unwritten standard to provide the project name. With this change we allow the project name to be provided using the --project command line argument and remove the ambiguity with other schematics.

@pullapprove pullapprove bot requested a review from AndrewKushnir July 1, 2022 11:37
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Jul 1, 2022
@alan-agius4 alan-agius4 added this to the Fixit H1'2022 milestone Jul 1, 2022
@ngbot ngbot bot removed this from the Fixit H1'2022 milestone Jul 1, 2022
@alan-agius4 alan-agius4 added the area: i18n Issues related to localization and internationalization label Jul 1, 2022
@ngbot ngbot bot added this to the Backlog milestone Jul 1, 2022
`--project` is unwritten standard to provide the project name. With this change we allow the project name to be provided using the `--project` command line argument and remove the ambiguity with other schematics.
@alan-agius4 alan-agius4 force-pushed the name-project-localize branch from d93a7e7 to 023a9c2 Compare July 1, 2022 11:46
@alan-agius4 alan-agius4 removed this from the Backlog milestone Jul 1, 2022
@ngbot ngbot bot added this to the Backlog milestone Jul 1, 2022
@alan-agius4 alan-agius4 modified the milestones: Backlog, Fixit H1'2022 Jul 1, 2022
@alan-agius4 alan-agius4 changed the title fix(@angular/localize): add --project option to ng-add schematic fix(localize): add --project option to ng-add schematic Jul 1, 2022
@AndrewKushnir
Copy link
Contributor

One quick question: should we log a message/warning when the name is used and recommend using project instead?

@alan-agius4
Copy link
Contributor Author

One quick question: should we log a message/warning when the name is used and recommend using project instead?

Instead of an alias, I deprecated the option. When used the CLI will issue a deprecation warning.

@alan-agius4 alan-agius4 force-pushed the name-project-localize branch from 4c057b1 to b33bc02 Compare July 1, 2022 18:32
@alan-agius4 alan-agius4 force-pushed the name-project-localize branch from b33bc02 to d2a732f Compare July 1, 2022 18:39
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alan-agius4 alan-agius4 force-pushed the name-project-localize branch from d2a732f to 6dd4c36 Compare July 1, 2022 18:49
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jul 1, 2022
@alxhub
Copy link
Member

alxhub commented Jul 6, 2022

This PR was merged into the repository by commit 392c567.

@alxhub alxhub closed this in 392c567 Jul 6, 2022
alxhub pushed a commit that referenced this pull request Jul 6, 2022
`--project` is unwritten standard to provide the project name. With this change we allow the project name to be provided using the `--project` command line argument and remove the ambiguity with other schematics.

PR Close #46664
@alan-agius4 alan-agius4 deleted the name-project-localize branch July 7, 2022 05:16
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request Jul 18, 2022
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@angular/animations](https://github.com/angular/angular) | dependencies | patch | [`14.0.5` -> `14.0.6`](https://renovatebot.com/diffs/npm/@angular%2fanimations/14.0.5/14.0.6) |
| [@angular/common](https://github.com/angular/angular) | dependencies | patch | [`14.0.5` -> `14.0.6`](https://renovatebot.com/diffs/npm/@angular%2fcommon/14.0.5/14.0.6) |
| [@angular/compiler](https://github.com/angular/angular) | dependencies | patch | [`14.0.5` -> `14.0.6`](https://renovatebot.com/diffs/npm/@angular%2fcompiler/14.0.5/14.0.6) |
| [@angular/compiler-cli](https://github.com/angular/angular) | devDependencies | patch | [`14.0.5` -> `14.0.6`](https://renovatebot.com/diffs/npm/@angular%2fcompiler-cli/14.0.5/14.0.6) |
| [@angular/core](https://github.com/angular/angular) | dependencies | patch | [`14.0.5` -> `14.0.6`](https://renovatebot.com/diffs/npm/@angular%2fcore/14.0.5/14.0.6) |
| [@angular/forms](https://github.com/angular/angular) | dependencies | patch | [`14.0.5` -> `14.0.6`](https://renovatebot.com/diffs/npm/@angular%2fforms/14.0.5/14.0.6) |
| [@angular/platform-browser](https://github.com/angular/angular) | dependencies | patch | [`14.0.5` -> `14.0.6`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser/14.0.5/14.0.6) |
| [@angular/platform-browser-dynamic](https://github.com/angular/angular) | dependencies | patch | [`14.0.5` -> `14.0.6`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser-dynamic/14.0.5/14.0.6) |

---

### Release Notes

<details>
<summary>angular/angular</summary>

### [`v14.0.6`](https://github.com/angular/angular/blob/HEAD/CHANGELOG.md#&#8203;1406-2022-07-13)

[Compare Source](angular/angular@14.0.5...14.0.6)

##### compiler-cli

| Commit | Type | Description |
| -- | -- | -- |
| [99697dae66](angular/angular@99697da) | fix | only consider used pipes for inline type-check requirement ([#&#8203;46807](angular/angular#46807)) |

##### forms

| Commit | Type | Description |
| -- | -- | -- |
| [4f469cbef3](angular/angular@4f469cb) | fix | expose ControlConfig in public API ([#&#8203;46594](angular/angular#46594)) |
| [e8c8b695f2](angular/angular@e8c8b69) | fix | Move all remaining errors in Forms to use RuntimeErrorCode. ([#&#8203;46654](angular/angular#46654)) |

##### localize

| Commit | Type | Description |
| -- | -- | -- |
| [14863acb1a](angular/angular@14863ac) | fix | add `--project` option to `ng-add` schematic ([#&#8203;46664](angular/angular#46664)) |

#### Special Thanks

Alan Agius, Andrew Scott, Bob Watson, Dylan Hunn, George Kalpakas, Ivaylo Kirov, Jessica Janiuk, JoostK, Joshua VanAllen, Lukas Matta, Marcin Wosinek, Nicolas Molina Monroy, Paul Gschwendtner, SoulsMark, Uday Sony, dario-piotrowicz, markostanimirovic and zhysky

<!-- CHANGELOG SPLIT MARKER -->

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xMTEuMSIsInVwZGF0ZWRJblZlciI6IjMyLjExMS4xIn0=-->

Co-authored-by: cabr2-bot <cabr2.help@gmail.com>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1459
Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org>
Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: i18n Issues related to localization and internationalization target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants