Skip to content

fix(forms): Move all remaining errors in Forms to use RuntimeErrorCode.#46654

Closed
dylhunn wants to merge 1 commit intoangular:mainfrom
dylhunn:forms-errs
Closed

fix(forms): Move all remaining errors in Forms to use RuntimeErrorCode.#46654
dylhunn wants to merge 1 commit intoangular:mainfrom
dylhunn:forms-errs

Conversation

@dylhunn
Copy link
Contributor

@dylhunn dylhunn commented Jun 30, 2022

RuntimeErrorCode allows for better tree-shaking, and unique codes for each error.

@dylhunn dylhunn added action: review The PR is still awaiting reviews from at least one requested reviewer area: forms target: patch This PR is targeted for the next patch release labels Jun 30, 2022
@dylhunn dylhunn added this to the Fixit H1'2022 milestone Jun 30, 2022
RuntimeErrorCode allows for better tree-shaking, and unique codes for each error.
Copy link
Contributor

@atscott atscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

@dylhunn dylhunn added action: presubmit The PR is in need of a google3 presubmit action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: review The PR is still awaiting reviews from at least one requested reviewer action: presubmit The PR is in need of a google3 presubmit labels Jun 30, 2022
@dylhunn
Copy link
Contributor Author

dylhunn commented Jul 1, 2022

merge-assistance: cannot remove extra reviewers

@atscott
Copy link
Contributor

atscott commented Jul 6, 2022

This PR was merged into the repository by commit e9b5dac.

@atscott atscott closed this in e9b5dac Jul 6, 2022
atscott pushed a commit that referenced this pull request Jul 6, 2022
…e. (#46654)

RuntimeErrorCode allows for better tree-shaking, and unique codes for each error.

PR Close #46654
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request Jul 18, 2022
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@angular/animations](https://github.com/angular/angular) | dependencies | patch | [`14.0.5` -> `14.0.6`](https://renovatebot.com/diffs/npm/@angular%2fanimations/14.0.5/14.0.6) |
| [@angular/common](https://github.com/angular/angular) | dependencies | patch | [`14.0.5` -> `14.0.6`](https://renovatebot.com/diffs/npm/@angular%2fcommon/14.0.5/14.0.6) |
| [@angular/compiler](https://github.com/angular/angular) | dependencies | patch | [`14.0.5` -> `14.0.6`](https://renovatebot.com/diffs/npm/@angular%2fcompiler/14.0.5/14.0.6) |
| [@angular/compiler-cli](https://github.com/angular/angular) | devDependencies | patch | [`14.0.5` -> `14.0.6`](https://renovatebot.com/diffs/npm/@angular%2fcompiler-cli/14.0.5/14.0.6) |
| [@angular/core](https://github.com/angular/angular) | dependencies | patch | [`14.0.5` -> `14.0.6`](https://renovatebot.com/diffs/npm/@angular%2fcore/14.0.5/14.0.6) |
| [@angular/forms](https://github.com/angular/angular) | dependencies | patch | [`14.0.5` -> `14.0.6`](https://renovatebot.com/diffs/npm/@angular%2fforms/14.0.5/14.0.6) |
| [@angular/platform-browser](https://github.com/angular/angular) | dependencies | patch | [`14.0.5` -> `14.0.6`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser/14.0.5/14.0.6) |
| [@angular/platform-browser-dynamic](https://github.com/angular/angular) | dependencies | patch | [`14.0.5` -> `14.0.6`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser-dynamic/14.0.5/14.0.6) |

---

### Release Notes

<details>
<summary>angular/angular</summary>

### [`v14.0.6`](https://github.com/angular/angular/blob/HEAD/CHANGELOG.md#&#8203;1406-2022-07-13)

[Compare Source](angular/angular@14.0.5...14.0.6)

##### compiler-cli

| Commit | Type | Description |
| -- | -- | -- |
| [99697dae66](angular/angular@99697da) | fix | only consider used pipes for inline type-check requirement ([#&#8203;46807](angular/angular#46807)) |

##### forms

| Commit | Type | Description |
| -- | -- | -- |
| [4f469cbef3](angular/angular@4f469cb) | fix | expose ControlConfig in public API ([#&#8203;46594](angular/angular#46594)) |
| [e8c8b695f2](angular/angular@e8c8b69) | fix | Move all remaining errors in Forms to use RuntimeErrorCode. ([#&#8203;46654](angular/angular#46654)) |

##### localize

| Commit | Type | Description |
| -- | -- | -- |
| [14863acb1a](angular/angular@14863ac) | fix | add `--project` option to `ng-add` schematic ([#&#8203;46664](angular/angular#46664)) |

#### Special Thanks

Alan Agius, Andrew Scott, Bob Watson, Dylan Hunn, George Kalpakas, Ivaylo Kirov, Jessica Janiuk, JoostK, Joshua VanAllen, Lukas Matta, Marcin Wosinek, Nicolas Molina Monroy, Paul Gschwendtner, SoulsMark, Uday Sony, dario-piotrowicz, markostanimirovic and zhysky

<!-- CHANGELOG SPLIT MARKER -->

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xMTEuMSIsInVwZGF0ZWRJblZlciI6IjMyLjExMS4xIn0=-->

Co-authored-by: cabr2-bot <cabr2.help@gmail.com>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1459
Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org>
Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 6, 2022
@dylhunn dylhunn deleted the forms-errs branch October 17, 2022 13:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: forms merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants