fix(core): align TestBed interfaces and implementation#46635
Closed
AndrewKushnir wants to merge 4 commits intoangular:mainfrom
Closed
fix(core): align TestBed interfaces and implementation#46635AndrewKushnir wants to merge 4 commits intoangular:mainfrom
AndrewKushnir wants to merge 4 commits intoangular:mainfrom
Conversation
f2734d6 to
e84d180
Compare
Contributor
Author
|
Presubmit (this change will also require a TGP) + a local patch in g3. |
atscott
approved these changes
Jun 30, 2022
Contributor
atscott
left a comment
There was a problem hiding this comment.
reviewed-for: public-api
dylhunn
approved these changes
Jun 30, 2022
Contributor
dylhunn
left a comment
There was a problem hiding this comment.
reviewed-for: public-api
jessicajaniuk
approved these changes
Jun 30, 2022
Contributor
jessicajaniuk
left a comment
There was a problem hiding this comment.
LGTM
reviewed-for: fw-core, fw-testing, circular-dependencies, public-api
9fa5f01 to
5301581
Compare
Contributor
Author
5e78262 to
217a3dc
Compare
This commit performs various refactoring of the TestBed code to better align interfaces and implementation. The implementation class is also renamed from `TestBedRender3` -> `TestBedImpl`, but the public API name has not changed. Note: as a part of this change, the TestBed interface became more consistent and typings for multiple methods were updated to account for the fact that the TestBed reference is returned. This was always a runtime behavior of TestBed, which was not reflected in few places in type.
This commit renames the `R3TestBedCompiler` -> `TestBedCompiler` to drop no longer needed Render3 prefix.
This commit updates TestBed-related files to drop the `r3_` prefix.
… cycles This commit combines TestBed interface and implementation to avoid cycles in the import graph. There are no functional or API changes.
217a3dc to
bd2b7e8
Compare
|
You can preview bd2b7e8 at https://pr46635-bd2b7e8.ngbuilds.io/. |
Contributor
Author
Contributor
Author
|
Global Presubmit #3 (to make sure there are no new regressions). |
Contributor
Author
|
Merge assistance: the PR has a "green" TGP, but it would still make sense to merge and land it in g3 separately from other changes. Regarding the PullApprove status: there is enough approvals from the group, so we can proceed with merging this PR. |
Contributor
|
This PR was merged into the repository by commit 7e03fc9. |
jessicajaniuk
pushed a commit
that referenced
this pull request
Jul 13, 2022
This commit renames the `R3TestBedCompiler` -> `TestBedCompiler` to drop no longer needed Render3 prefix. PR Close #46635
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains 3 commits with the TestBed implementation cleanup.
The change affected the public API surface, but in practice those types were already exposed via the TestBedStatic interface, so those APIs were already public.
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?