Skip to content

Commit bd2b7e8

Browse files
AndrewKushnirAndrewKushnir
committed
refactor(core): combine TestBed interface and implementation to avoid cycles
This commit combines TestBed interface and implementation to avoid cycles in the import graph. There are no functional or API changes.
1 parent 2dafbb1 commit bd2b7e8

File tree

7 files changed

+622
-650
lines changed

7 files changed

+622
-650
lines changed

‎goldens/circular-deps/packages.json‎

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -162,14 +162,6 @@
162162
"packages/core/src/render3/interfaces/query.ts",
163163
"packages/core/src/render3/interfaces/view.ts"
164164
],
165-
[
166-
"packages/core/testing/src/test_bed_common.ts",
167-
"packages/core/testing/src/test_bed.ts"
168-
],
169-
[
170-
"packages/core/testing/src/test_bed_impl.ts",
171-
"packages/core/testing/src/test_bed.ts"
172-
],
173165
[
174166
"packages/forms/src/directives.ts",
175167
"packages/forms/src/directives/ng_control_status.ts",

‎packages/core/test/test_bed_spec.ts‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,7 @@
77
*/
88

99
import {APP_INITIALIZER, ChangeDetectorRef, Compiler, Component, Directive, ElementRef, ErrorHandler, getNgModuleById, Inject, Injectable, InjectionToken, Injector, Input, LOCALE_ID, ModuleWithProviders, NgModule, Optional, Pipe, Type, ViewChild, ɵsetClassMetadata as setClassMetadata, ɵɵdefineComponent as defineComponent, ɵɵdefineInjector as defineInjector, ɵɵdefineNgModule as defineNgModule, ɵɵelementEnd as elementEnd, ɵɵelementStart as elementStart, ɵɵsetNgModuleScope as setNgModuleScope, ɵɵtext as text} from '@angular/core';
10-
import {TestBed} from '@angular/core/testing/src/test_bed';
11-
import {TestBedImpl} from '@angular/core/testing/src/test_bed_impl';
10+
import {TestBed, TestBedImpl} from '@angular/core/testing/src/test_bed';
1211
import {By} from '@angular/platform-browser';
1312
import {expect} from '@angular/platform-browser/testing/src/matchers';
1413

0 commit comments

Comments
 (0)