fix(forms): expose ControlConfig in public API by udaysonyy · Pull Request #46594 · angular/angular

udaysonyy · 2022-06-29T10:20:36Z

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ x ] Bugfix
Feature
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Documentation content changes
angular.io application / infrastructure changes
Other... Please describe:

What is the current behavior?

Issue Number: #46570

What is the new behavior?

We can use ControlConfig type in application

import { ControlConfig } from '@angular/forms';

Does this PR introduce a breaking change?

Yes
[ x ] No

Other information

google-cla · 2022-06-29T10:20:43Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

udaysonyy · 2022-06-29T10:28:35Z

I have signed Contributor License Agreement (CLA).

dylhunn · 2022-06-29T16:24:46Z

@udaysonyy It looks like this needs to be formatted:

yarn ng-dev format files packages/forms/src/forms.ts

as well as have the API changes accepted:

yarn bazel run //packages/forms:forms_api.accept

Then you'll want to amend your current commit:

git add .
git commit --no-edit --amend

udaysonyy · 2022-06-30T09:56:30Z

When I tried to run yarn bazel run //packages/forms:forms_api.accept, i am getting this error i tried my best but it's the same.

udaysonyy · 2022-07-01T09:15:43Z

I've tried so much but yarn is not working properly...

AndrewKushnir · 2022-07-08T00:43:27Z

@udaysonyy FYI I've updated this PR to reflect the change in the golden file.

@dylhunn could you please take a look at this change once again when you get a chance?

dylhunn

reviewed-for: fw-forms, public-api

Looks good, ~~but it's odd that pullapprove isn't asking for public-api approval~~ (this resolved itself). Also, I think the error in the components integration test CI result is a configuration problem or flake.

AndrewKushnir

Reviewed-for: public-api

jessicajaniuk · 2022-07-12T16:45:10Z

This PR needs a rebase to latest main fix the components-repo-unit-tests.

jessicajaniuk

reviewed-for: public-api

This commit exposes the ControlConfig as a public API, so that the symbol can be used in applications.

jessicajaniuk · 2022-07-12T16:55:54Z

Presubmit

jessicajaniuk · 2022-07-12T17:45:39Z

This PR was merged into the repository by commit c0ca3fc.

This commit exposes the ControlConfig as a public API, so that the symbol can be used in applications. PR Close #46594

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/animations](https://github.com/angular/angular) | dependencies | patch | [`14.0.5` -> `14.0.6`](https://renovatebot.com/diffs/npm/@angular%2fanimations/14.0.5/14.0.6) | | [@angular/common](https://github.com/angular/angular) | dependencies | patch | [`14.0.5` -> `14.0.6`](https://renovatebot.com/diffs/npm/@angular%2fcommon/14.0.5/14.0.6) | | [@angular/compiler](https://github.com/angular/angular) | dependencies | patch | [`14.0.5` -> `14.0.6`](https://renovatebot.com/diffs/npm/@angular%2fcompiler/14.0.5/14.0.6) | | [@angular/compiler-cli](https://github.com/angular/angular) | devDependencies | patch | [`14.0.5` -> `14.0.6`](https://renovatebot.com/diffs/npm/@angular%2fcompiler-cli/14.0.5/14.0.6) | | [@angular/core](https://github.com/angular/angular) | dependencies | patch | [`14.0.5` -> `14.0.6`](https://renovatebot.com/diffs/npm/@angular%2fcore/14.0.5/14.0.6) | | [@angular/forms](https://github.com/angular/angular) | dependencies | patch | [`14.0.5` -> `14.0.6`](https://renovatebot.com/diffs/npm/@angular%2fforms/14.0.5/14.0.6) | | [@angular/platform-browser](https://github.com/angular/angular) | dependencies | patch | [`14.0.5` -> `14.0.6`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser/14.0.5/14.0.6) | | [@angular/platform-browser-dynamic](https://github.com/angular/angular) | dependencies | patch | [`14.0.5` -> `14.0.6`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser-dynamic/14.0.5/14.0.6) | --- ### Release Notes <details> <summary>angular/angular</summary> ### [`v14.0.6`](https://github.com/angular/angular/blob/HEAD/CHANGELOG.md#1406-2022-07-13) [Compare Source](angular/angular@14.0.5...14.0.6) ##### compiler-cli | Commit | Type | Description | | -- | -- | -- | | [99697dae66](angular/angular@99697da) | fix | only consider used pipes for inline type-check requirement ([#46807](angular/angular#46807)) | ##### forms | Commit | Type | Description | | -- | -- | -- | | [4f469cbef3](angular/angular@4f469cb) | fix | expose ControlConfig in public API ([#46594](angular/angular#46594)) | | [e8c8b695f2](angular/angular@e8c8b69) | fix | Move all remaining errors in Forms to use RuntimeErrorCode. ([#46654](angular/angular#46654)) | ##### localize | Commit | Type | Description | | -- | -- | -- | | [14863acb1a](angular/angular@14863ac) | fix | add `--project` option to `ng-add` schematic ([#46664](angular/angular#46664)) | #### Special Thanks Alan Agius, Andrew Scott, Bob Watson, Dylan Hunn, George Kalpakas, Ivaylo Kirov, Jessica Janiuk, JoostK, Joshua VanAllen, Lukas Matta, Marcin Wosinek, Nicolas Molina Monroy, Paul Gschwendtner, SoulsMark, Uday Sony, dario-piotrowicz, markostanimirovic and zhysky  </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1459 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>

angular-automatic-lock-bot · 2022-08-12T16:06:58Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

pullapprove bot requested a review from dylhunn June 29, 2022 10:20

dylhunn added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews area: forms target: patch This PR is targeted for the next patch release labels Jun 29, 2022

ngbot bot modified the milestone: Backlog Jun 29, 2022

AndrewKushnir force-pushed the my-fix-branch branch from dc82e14 to 9bba90f Compare July 8, 2022 00:41

AndrewKushnir added action: review The PR is still awaiting reviews from at least one requested reviewer and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Jul 8, 2022

AndrewKushnir force-pushed the my-fix-branch branch from 9bba90f to b92847f Compare July 8, 2022 02:01

dylhunn approved these changes Jul 12, 2022

View reviewed changes

pullapprove bot requested review from AndrewKushnir, jessicajaniuk and pkozlowski-opensource July 12, 2022 16:32

AndrewKushnir approved these changes Jul 12, 2022

View reviewed changes

jessicajaniuk approved these changes Jul 12, 2022

View reviewed changes

jessicajaniuk removed the request for review from pkozlowski-opensource July 12, 2022 16:46

jessicajaniuk added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jul 12, 2022

fix(forms): expose ControlConfig in public API

9c1da17

This commit exposes the ControlConfig as a public API, so that the symbol can be used in applications.

AndrewKushnir force-pushed the my-fix-branch branch from b92847f to 9c1da17 Compare July 12, 2022 16:50

AndrewKushnir added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Jul 12, 2022

angular-robot bot requested a review from jessicajaniuk July 12, 2022 16:51

jessicajaniuk approved these changes Jul 12, 2022

View reviewed changes

jessicajaniuk added action: presubmit The PR is in need of a google3 presubmit and removed action: presubmit The PR is in need of a google3 presubmit labels Jul 12, 2022

jessicajaniuk closed this in c0ca3fc Jul 12, 2022

jessicajaniuk pushed a commit that referenced this pull request Jul 12, 2022

fix(forms): expose ControlConfig in public API (#46594)

4f469cb

This commit exposes the ControlConfig as a public API, so that the symbol can be used in applications. PR Close #46594

angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 12, 2022

Conversation

udaysonyy commented Jun 29, 2022

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information

Uh oh!

google-cla bot commented Jun 29, 2022

Uh oh!

udaysonyy commented Jun 29, 2022

Uh oh!

dylhunn commented Jun 29, 2022

Uh oh!

udaysonyy commented Jun 30, 2022

Uh oh!

udaysonyy commented Jul 1, 2022

Uh oh!

AndrewKushnir commented Jul 8, 2022

Uh oh!

dylhunn left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AndrewKushnir left a comment

Choose a reason for hiding this comment

Uh oh!

jessicajaniuk commented Jul 12, 2022

Uh oh!

jessicajaniuk left a comment

Choose a reason for hiding this comment

Uh oh!

jessicajaniuk commented Jul 12, 2022

Uh oh!

jessicajaniuk commented Jul 12, 2022

Uh oh!

angular-automatic-lock-bot bot commented Aug 12, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dylhunn left a comment •

edited

Loading