fix(core): Ensure the StandaloneService is retained after closure m…#45783
Closed
atscott wants to merge 1 commit intoangular:masterfrom
Closed
fix(core): Ensure the StandaloneService is retained after closure m…#45783atscott wants to merge 1 commit intoangular:masterfrom
StandaloneService is retained after closure m…#45783atscott wants to merge 1 commit intoangular:masterfrom
Conversation
…inification In order to survive closure minification correctly, static properties need to be annotated with @nocollapse. For more history, see angular#28050
Contributor
Author
AndrewKushnir
approved these changes
Apr 27, 2022
Contributor
AndrewKushnir
left a comment
There was a problem hiding this comment.
Great find, thanks @atscott 👍
Contributor
|
This PR was merged into the repository by commit f3eb7d9. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…inification
In order to survive closure minification correctly, static properties need to
be annotated with @nocollapse.
For more history, see #28050