Various XSD improvements (NLog.Schema package)#3409
Merged
304NotModified merged 3 commits intorelease/4.6.4from May 24, 2019
Merged
Various XSD improvements (NLog.Schema package)#3409304NotModified merged 3 commits intorelease/4.6.4from
304NotModified merged 3 commits intorelease/4.6.4from
Conversation
3a18ab5 to
8d3f2c7
Compare
Contributor
|
@304NotModified Think you should also fix this method to recognize private LoggingRule ParseRuleElement(ILoggingConfigurationElement loggerElement)
{
IEnumerable<LogLevel> enableLevels = null;
int minLevel = 0;
int maxLevel = LogLevel.MaxLevel.Ordinal;
string ruleName = null;
string namePattern = null;
bool enabled = true;
bool final = false;
string writeTargets = null;
foreach (var childProperty in loggerElement.Values)
{
switch (childProperty.Key?.Trim().ToUpperInvariant())
{
case "NAME":
if (loggerElement.MatchesName("logger"))
namePattern = childProperty.Value; // Legacy Style
else
ruleName = childProperty.Value;
break;
case "RULENAME":
ruleName = childProperty.Value; // Legacy Style
break; |
Member
Author
This isn't an issue in the XML now isn't? |
Member
Author
|
I think we have to update the XSD for NLog 5 and recommend the new approach IMO |
Contributor
Nope but it would make sense that |
Member
Author
|
ow this is a mistake then. I'm confused why the names aren't in sync... |
Codecov Report
@@ Coverage Diff @@
## release/4.6.4 #3409 +/- ##
==============================================
+ Coverage 80% 80% +<1%
==============================================
Files 358 358
Lines 28373 28378 +5
Branches 3785 3786 +1
==============================================
+ Hits 22750 22763 +13
+ Misses 4537 4521 -16
- Partials 1086 1094 +8 |
Contributor
|
Created #3411 |
8d3f2c7 to
1fcd91d
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #3377
related #2394 and #2891