WordPress.org
Get WordPress

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 11 months ago

#58889 closed defect (bug) (fixed)

Fix template parts mode check in site-editor.php

Reported by: mamaduka's profile Mamaduka Owned by: audrasjb's profile audrasjb
Milestone: 6.3 Priority: normal
Severity: normal Version: 6.3
Component: Editor Keywords: has-test-info has-patch commit dev-reviewed fixed-major
Focuses: Cc:

Description

Recently Site Editor client-side routing started using only the path query argument for loading non-editor views.

The router removes the postType query argument, which causes an error message to be displayed when you reload the template parts list page.

  1. Activate a theme that enables block-based template parts - ​https://github.com/Mamaduka/block-fragments or ​https://github.com/WordPress/gutenberg/tree/trunk/test/gutenberg-test-themes/emptyhybrid.
  2. Visit the new Appearance > Template Parts menu.
  3. Reload the page.
  4. Notice that "The theme you are currently using is not compatible with the Site Editor." message is displayed.

Change History (13)

This ticket was mentioned in ​PR #4893 on ​WordPress/wordpress-develop by ​@Mamaduka.
3 years ago #1

  • Keywords has-patch added

Trac ticket: https://core.trac.wordpress.org/ticket/58889

​@isabel_brison commented on ​PR #4893:
3 years ago #2

Hey @Mamaduka is this PR meant for WP 6.3?

​@Mamaduka commented on ​PR #4893:
3 years ago #3

@tellthemachines, I think we should land this in 6.3; otherwise, we'll have annoying regression for hybrid themes.

#4 @ramonopoly
3 years ago

  • Milestone changed from Awaiting Review to 6.3
  • Version set to trunk

#5 @audrasjb
3 years ago

  • Keywords commit added

PR4893 seems ready for commit.
Also approving this for backport to branch 6.3.

#6 @audrasjb
3 years ago

  • Keywords dev-reviewed added

#7 @audrasjb
3 years ago

@Mamaduka @ramonopoly do you confirm that PR is ready to ship in RC2?

#8 @Mamaduka
3 years ago

Yes, it should be good to shop in RC2. It just needs a commit and backport.

#9 @audrasjb
3 years ago

  • Owner set to audrasjb
  • Resolution set to fixed
  • Status changed from new to closed

In 56302:

Editor: Fix conditionals in Template Editing Mode.

Previously, Site Editor client-side routing started using only the path query argument for loading non-editor views. The router removed the postType query
argument, which caused an error message to be displayed when the template parts list page was reloaded.

This changeset fixes the issue as it was affecting hybrid themes.

Props Mamaduka, isabel_brison, ramonopoly.
Fixes #58889.

#11 @audrasjb
3 years ago

  • Keywords fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

#12 @audrasjb
3 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 56303:

Editor: Fix conditionals in Template Editing Mode.

Previously, Site Editor client-side routing started using only the path query argument for loading non-editor views. The router removed the postType query
argument, which caused an error message to be displayed when the template parts list page was reloaded.

This changeset fixes the issue as it was affecting hybrid themes.

Props Mamaduka, isabel_brison, ramonopoly.
Reviewed by isabel_brison, audrasjb.
Merges [56302] to the 6.3 branch.
Fixes #58889.

#13 @wordpressdotorg
11 months ago

  • Keywords has-test-info added; has-testing-info removed
Note: See TracTickets for help on using tickets.