Skip to content

Commit 10d5c98

Browse files
ConstellationConstellation
committed
[JSC] Enable AsyncStackTrace
https://bugs.webkit.org/show_bug.cgi?id=306918 rdar://169587801 Reviewed by Sosuke Suzuki. We carefully did A/B test and confirmed it is neutral. So let's enable it. AsyncStackTrace will offer stack trace with asynchronous context which keeps entries connected from the previous async execution. * LayoutTests/http/tests/webgpu/webgpu/api/operation/uncapturederror-expected.txt: * LayoutTests/http/tests/webgpu/webgpu/api/validation/capability_checks/limits/maxInterStageShaderVariables-expected.txt: * LayoutTests/http/tests/webgpu/webgpu/shader/execution/flow_control/eval_order-expected.txt: * Source/JavaScriptCore/runtime/OptionsList.h: Canonical link: https://commits.webkit.org/306759@main
1 parent e9964c3 commit 10d5c98

4 files changed

Lines changed: 389 additions & 1 deletion

File tree

‎LayoutTests/http/tests/webgpu/webgpu/api/operation/uncapturederror-expected.txt‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,16 @@ FAIL :iff_uncaptured:useOnuncapturederror=true;errorType="out-of-memory" assert_
66
assert@http://127.0.0.1:8000/webgpu/common/util/util.js:37:20
77
finalize@http://127.0.0.1:8000/webgpu/common/framework/fixture.js:119:11
88
runTest@http://127.0.0.1:8000/webgpu/common/internal/test_group.js:534:28
9+
async run@http://127.0.0.1:8000/webgpu/common/internal/test_group.js:682:31
10+
@http://127.0.0.1:8000/webgpu/common/runtime/wpt.js:75:27
911
Reached unreachable code
1012
FAIL :iff_uncaptured:useOnuncapturederror=true;errorType="validation" assert_unreached:
1113
- EXCEPTION: Error: there were outstanding immediateAsyncExpectations (e.g. expectUncapturedError) at the end of the test
1214
assert@http://127.0.0.1:8000/webgpu/common/util/util.js:37:20
1315
finalize@http://127.0.0.1:8000/webgpu/common/framework/fixture.js:119:11
1416
runTest@http://127.0.0.1:8000/webgpu/common/internal/test_group.js:534:28
17+
async run@http://127.0.0.1:8000/webgpu/common/internal/test_group.js:682:31
18+
@http://127.0.0.1:8000/webgpu/common/runtime/wpt.js:75:27
1519
Reached unreachable code
1620
PASS :only_original_device_is_event_target:
1721
PASS :uncapturederror_from_non_originating_thread:

0 commit comments

Comments
 (0)