CaretPosition should be EnabledBySetting

nt1m · nt1m · commit c4e24f803946 · 2025-02-28T04:30:44.000-08:00
https://bugs.webkit.org/show_bug.cgi?id=288644 rdar://145688017 Reviewed by Simon Fraser. https://commits.webkit.org/287047@main (bug 172137) added Document.caretPositionFromPoint(). However, while Document.caretPositionFromPoint() itself has [EnabledBySetting=CaretPositionFromPointEnabled] neither CaretPosition nor CaretPositionFromPointOptions do. These should also be behind the flag, because otherwise we break anyone doing anything like `if (window.CaretPosition)` or the mdn-bcd-collector trying to fetch meaningful data about what browser supports the related APIs. * Source/WebCore/bindings/js/WebCoreBuiltinNames.h: * Source/WebCore/dom/CaretPosition.idl: Canonical link: https://commits.webkit.org/291314@main
diff --git a/Source/WebCore/bindings/js/WebCoreBuiltinNames.h b/Source/WebCore/bindings/js/WebCoreBuiltinNames.h
@@ -107,6 +107,7 @@ namespace WebCore {
     macro(BufferedChangeEvent) \
     macro(Cache) \
     macro(CacheStorage) \
+    macro(CaretPosition) \
     macro(ChannelMergerNode) \
     macro(ChannelSplitterNode) \
     macro(Client) \
diff --git a/Source/WebCore/dom/CaretPosition.idl b/Source/WebCore/dom/CaretPosition.idl
@@ -24,6 +24,7 @@
  */
 
 [
+    EnabledBySetting=CaretPositionFromPointEnabled,
     ExportMacro=WEBCORE_EXPORT,
     Exposed=(Window),
     TaggedWrapper,

Original file line number	Diff line number	Diff line change
`@@ -24,6 +24,7 @@`
`24`	`24`	`*/`
`25`	`25`
`26`	`26`	`[`
	`27`	`+ EnabledBySetting=CaretPositionFromPointEnabled,`
`27`	`28`	`ExportMacro=WEBCORE_EXPORT,`
`28`	`29`	`Exposed=(Window),`
`29`	`30`	`TaggedWrapper,`