feat: autocomplete choices for options#2018
Merged
bcoe merged 2 commits intoyargs:masterfrom Sep 5, 2021
Merged
Conversation
bcoe
approved these changes
Sep 5, 2021
Member
bcoe
left a comment
There was a problem hiding this comment.
This seems like a great addition to completion functionality 👍 and I appreciate the fix for TypeScript.
rvitaliy
reviewed
Sep 23, 2021
| }); | ||
| } catch (err) { | ||
| console.warn(err.stack); | ||
| console.warn((err as Error).stack); |
There was a problem hiding this comment.
👋 hi all, here my 50cent, sorry!
The scope of usage unknown instead of any is to prevent fatal errors when catch receive something what is not an Error.
"errorString".stack > fatal error
to avoid this i suggest to add a check if err is instance of Error like suggested by documentation instead of cast err as Error
https://devblogs.microsoft.com/typescript/announcing-typescript-4-4/#use-unknown-catch-variables
hongaar
added a commit
to hongaar/bandersnatch
that referenced
this pull request
Sep 23, 2021
Choices autocompletion is now available from upstream yargs, see yargs/yargs#2018
This was referenced Nov 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
This PR introduces support for auto completing choices if an option has been specified which has choices but no value has been selected yet. For example:
when the option has been specified like this: (source)
Background
We use
yargsfor the CDK for Terraform and wanted to introduce support for shell completion. As we wanted to offer support for auto completing choices for options, I figured I'd do a PR instead of building a custom completion handler in multiple places.If there's anything I can do to get this merged, please tell me!
P.S. It also fixes #2016 because that caused the build to fail for me and there's no
package-lock.jsonor alike.