fix: help command spacing when scriptName is empty#1994
Merged
bcoe merged 4 commits intoyargs:masterfrom Aug 16, 2021
CupOfTea696:patch-1
Merged
fix: help command spacing when scriptName is empty#1994bcoe merged 4 commits intoyargs:masterfrom CupOfTea696:patch-1
bcoe merged 4 commits intoyargs:masterfrom
CupOfTea696:patch-1
Conversation
Contributor
Author
|
Example: When using yargs()
.scriptName('')
.command('group', 'Rule groups')
.command('rule', 'Rule management')
.command('help [command] [subcommand]', 'Show help')Output: With fix: |
bcoe
approved these changes
Aug 4, 2021
Member
|
@CupOfTea696 thank you for the contribution 👏 right now this looks to be breaking a couple tests, mind taking a look? |
Contributor
Author
|
@bcoe That should fix it. |
This was referenced Nov 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When settings the scriptName to an empty string, the help command will add an unnecessary whitespace before commands, and wrap the command usage string 1 character too early. This PR fixes this.