fix: add mypy checking + 'py.typed' files #149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tswast
approved these changes
Oct 13, 2021
tswast
requested changes
Oct 13, 2021
FBO typing, which interprets 'py.typed' file as always-inherited in subdirs.
tswast
reviewed
Nov 5, 2021
setup.py
Outdated
|
|
||
| version = {} | ||
| with open(os.path.join(package_root, "google/cloud/version.py")) as fp: | ||
| with open(os.path.join(package_root, "google/cloud/version/__init__.py")) as fp: |
Contributor
There was a problem hiding this comment.
This might require an update to https://github.com/googleapis/release-please/blob/main/src/releasers/python.ts
Contributor
Author
There was a problem hiding this comment.
Rather than that, maybe we just back out converting google/cloud/version.py to a package? I don't really see anybody choking on lack of typing when importing the one attribute in that module.
Contributor
There was a problem hiding this comment.
Sounds good to me. It's literally just 1 string, so I'm okay with that.
Our 'release-please' tooling won't find it there, and nobody is likely to a) import the module, and then b) choke on its lack of typing.
tswast
approved these changes
Nov 9, 2021
Contributor
|
Confirmed that it's passing on Kokoro: |
Contributor
|
This should go in a minor release, not a patch release. I probably should have marked as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.