Skip to content

fix: only throw if storageClass and specific storage class name provide different values #1346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stephenplusplus merged 3 commits into from
Dec 1, 2020
Merged

fix: only throw if storageClass and specific storage class name provide different values #1346

stephenplusplus merged 3 commits into from
Dec 1, 2020

Conversation

@AVaksman
Copy link
Contributor

@AVaksman AVaksman commented Nov 30, 2020

To complement #1323 changes

  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@AVaksman AVaksman requested a review from a team as a code owner November 30, 2020 20:55
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/nodejs-storage API. label Nov 30, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 30, 2020
@codecov
Copy link

codecov bot commented Nov 30, 2020 •
edited
Loading

Codecov Report

Merging #1346 (5ab9e56) into master (ea2c2c9) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1346   +/-   ##
=======================================
  Coverage   99.00%   99.00%           
=======================================
  Files          14       14           
  Lines       11804    11804           
  Branches      595      526   -69     
=======================================
  Hits        11687    11687           
  Misses        117      117
Impacted Files Coverage Δ
src/storage.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea2c2c9...5ab9e56. Read the comment docs.

shaffeeullah
shaffeeullah reviewed Nov 30, 2020
View reviewed changes
test/index.ts Outdated
});
});

it('should throw when `storageClass` is set do different value than provided storageClass name', () => {
Copy link
Contributor

@shaffeeullah shaffeeullah Nov 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set to different value (typo)

Copy link
Contributor Author

@AVaksman AVaksman Dec 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thanks

@stephenplusplus stephenplusplus merged commit 1765608 into googleapis:master Dec 1, 2020
gcf-owl-bot bot added a commit that referenced this pull request Feb 3, 2022
@gcf-owl-bot
docs(nodejs): version support policy edits (#1346)
14f88ed 
Source-Link: googleapis/synthtool@d815daf
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:a9d166a74752226923d159cb723df53429e226c9c076dad3ca52ffd073ff3bb4
gcf-merge-on-green bot pushed a commit that referenced this pull request Feb 4, 2022
@gcf-owl-bot
docs(nodejs): version support policy edits (#1346) (#1777)
04791c7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@stephenplusplus stephenplusplus stephenplusplus approved these changes

@shaffeeullah shaffeeullah shaffeeullah approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: storage Issues related to the googleapis/nodejs-storage API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AVaksman @stephenplusplus @shaffeeullah