Skip to content

Conversation

@jkwlui
Copy link
Member

@jkwlui jkwlui commented Feb 12, 2020

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 12, 2020
@jkwlui jkwlui changed the base branch from v4-additional-query-params to master February 12, 2020 00:33
@jkwlui jkwlui changed the base branch from master to v4-additional-query-params February 12, 2020 00:34
@jkwlui jkwlui force-pushed the v4-additional-query-params branch from b1f43f3 to ed2fbfc Compare February 12, 2020 00:35
@jkwlui jkwlui changed the base branch from v4-additional-query-params to v4-ga February 13, 2020 00:01
@jkwlui jkwlui changed the base branch from v4-ga to v4-additional-query-params February 13, 2020 00:02
@jkwlui jkwlui changed the base branch from v4-additional-query-params to v4-ga February 13, 2020 00:06
@jkwlui jkwlui requested a review from frankyn February 13, 2020 00:06
@jkwlui jkwlui requested a review from frankyn February 14, 2020 23:23
Copy link
Contributor

@frankyn frankyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @jkwlui

@jkwlui jkwlui merged commit ddeeafe into v4-ga Feb 14, 2020
@jkwlui jkwlui deleted the v4-signed-payload branch February 14, 2020 23:34
jkwlui added a commit that referenced this pull request Mar 5, 2020
* feat(signed-url): support list bucket (#1051)

* refactor signed url logic into its own class

* fix the test

* refactor tests to test/signer.ts

* npm run fix

* chore: generate synth.metadata

* allow bucket-operation signed url

* remove unused types

* support bucket operations

* refactor signer to not use promisify

* fix node-8 test

* add test for generation parameter

* test: add list bucket signed url system-test

* npm run fix

* fix bucket getSignedUrl docs

* chore(deps): update dependency @types/mocha to v7

* fix: unhandled promise rejection warning in samples (#1056)

* fix: unhandledPromiseRejectionWarning in samples

* fix: lint issue

* fix: lint issue

Co-authored-by: Benjamin E. Coe <bencoe@google.com>

* docs(readme): log errors in sample

* chore: skip img.shields.io in docs test

Co-authored-by: Yoshi Automation Bot <yoshi-automation@google.com>
Co-authored-by: WhiteSource Renovate <renovatebot@gmail.com>
Co-authored-by: Lalji Kanjareeya <46327204+laljikanjareeya@users.noreply.github.com>
Co-authored-by: Benjamin E. Coe <bencoe@google.com>
Co-authored-by: Justin Beckwith <justin.beckwith@gmail.com>

* test(signed-url): update conformance test json to conformance-test@9f134282 (#1066)

* update conformance test json to conformance-test@9f134282

* parse updated conformance-test format

* npm run fix

* pass queryParameters to conformance test

* conformance tests ignore query parameter ordering in URL

* npm run fix

* parse sha256 option

* revert debug

* fix(signed-url): trailing `/` after path before query params (#1068)

* update conformance test json to conformance-test@9f134282

* parse updated conformance-test format

* npm run fix

* fix(signed-url): trailing `/` after path before query params

* fix(signed-url): fix query parameter signing (#1069)

* update conformance test json to conformance-test@9f134282

* parse updated conformance-test format

* npm run fix

* pass queryParameters to conformance test

* conformance tests ignore query parameter ordering in URL

* npm run fix

* parse sha256 option

* revert debug

* fix(signed-url): include custom query parameters in signature calculation

* query param wip

* fix queryParam sorting

* test: query params are sorted

* remove unused imports

* npm run fix

* refactor

* rename QueryParams to just Query

* feat(signed-url): support virtual hosted style url (#1067)

* update conformance test json to conformance-test@9f134282

* parse updated conformance-test format

* npm run fix

* vhost

* unit tests

* npm run fix

* docs: document urlStyle option for Bucket

* test: add system-test to exercise virtual-hosted url

* pass queryParameters to conformance test

* conformance tests ignore query parameter ordering in URL

* npm run fix

* parse sha256 option

* revert debug

* restyle option as virtualHostedStyle as a boolean

* npm run fix

* docs: virtualHostedStyle option defaults to false

* docs: fix path style example

* fix: resource path beginning with /

* feat(signed-url): support SHA256 for signed payloads (#1070)

* feat(signed-url): support SHA256 for signed payloads

* add unit test

* remove junk import

* newline

* document contentMd5 option

* do not provide contentSha256 option, instead, detect user provided header

* npm run fix

* fix system-test

* test: expand URLSigner test

* fix(refactor): rename UrlSigner to URLSigner

* localize URLSigner unit tests

* address PR comments

* npm run fix

Co-authored-by: Yoshi Automation Bot <yoshi-automation@google.com>
Co-authored-by: WhiteSource Renovate <renovatebot@gmail.com>
Co-authored-by: Lalji Kanjareeya <46327204+laljikanjareeya@users.noreply.github.com>
Co-authored-by: Benjamin E. Coe <bencoe@google.com>
Co-authored-by: Justin Beckwith <justin.beckwith@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants