-
Notifications
You must be signed in to change notification settings - Fork 391
feat(signed-url): support SHA256 for signed payloads #1070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b1f43f3 to
ed2fbfc
Compare
3026307 to
6cdc8a6
Compare
88a7eef to
eda2c0f
Compare
frankyn
suggested changes
Feb 13, 2020
frankyn
approved these changes
Feb 14, 2020
Contributor
frankyn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @jkwlui
jkwlui
added a commit
that referenced
this pull request
Mar 5, 2020
* feat(signed-url): support list bucket (#1051) * refactor signed url logic into its own class * fix the test * refactor tests to test/signer.ts * npm run fix * chore: generate synth.metadata * allow bucket-operation signed url * remove unused types * support bucket operations * refactor signer to not use promisify * fix node-8 test * add test for generation parameter * test: add list bucket signed url system-test * npm run fix * fix bucket getSignedUrl docs * chore(deps): update dependency @types/mocha to v7 * fix: unhandled promise rejection warning in samples (#1056) * fix: unhandledPromiseRejectionWarning in samples * fix: lint issue * fix: lint issue Co-authored-by: Benjamin E. Coe <bencoe@google.com> * docs(readme): log errors in sample * chore: skip img.shields.io in docs test Co-authored-by: Yoshi Automation Bot <yoshi-automation@google.com> Co-authored-by: WhiteSource Renovate <renovatebot@gmail.com> Co-authored-by: Lalji Kanjareeya <46327204+laljikanjareeya@users.noreply.github.com> Co-authored-by: Benjamin E. Coe <bencoe@google.com> Co-authored-by: Justin Beckwith <justin.beckwith@gmail.com> * test(signed-url): update conformance test json to conformance-test@9f134282 (#1066) * update conformance test json to conformance-test@9f134282 * parse updated conformance-test format * npm run fix * pass queryParameters to conformance test * conformance tests ignore query parameter ordering in URL * npm run fix * parse sha256 option * revert debug * fix(signed-url): trailing `/` after path before query params (#1068) * update conformance test json to conformance-test@9f134282 * parse updated conformance-test format * npm run fix * fix(signed-url): trailing `/` after path before query params * fix(signed-url): fix query parameter signing (#1069) * update conformance test json to conformance-test@9f134282 * parse updated conformance-test format * npm run fix * pass queryParameters to conformance test * conformance tests ignore query parameter ordering in URL * npm run fix * parse sha256 option * revert debug * fix(signed-url): include custom query parameters in signature calculation * query param wip * fix queryParam sorting * test: query params are sorted * remove unused imports * npm run fix * refactor * rename QueryParams to just Query * feat(signed-url): support virtual hosted style url (#1067) * update conformance test json to conformance-test@9f134282 * parse updated conformance-test format * npm run fix * vhost * unit tests * npm run fix * docs: document urlStyle option for Bucket * test: add system-test to exercise virtual-hosted url * pass queryParameters to conformance test * conformance tests ignore query parameter ordering in URL * npm run fix * parse sha256 option * revert debug * restyle option as virtualHostedStyle as a boolean * npm run fix * docs: virtualHostedStyle option defaults to false * docs: fix path style example * fix: resource path beginning with / * feat(signed-url): support SHA256 for signed payloads (#1070) * feat(signed-url): support SHA256 for signed payloads * add unit test * remove junk import * newline * document contentMd5 option * do not provide contentSha256 option, instead, detect user provided header * npm run fix * fix system-test * test: expand URLSigner test * fix(refactor): rename UrlSigner to URLSigner * localize URLSigner unit tests * address PR comments * npm run fix Co-authored-by: Yoshi Automation Bot <yoshi-automation@google.com> Co-authored-by: WhiteSource Renovate <renovatebot@gmail.com> Co-authored-by: Lalji Kanjareeya <46327204+laljikanjareeya@users.noreply.github.com> Co-authored-by: Benjamin E. Coe <bencoe@google.com> Co-authored-by: Justin Beckwith <justin.beckwith@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.