fix: update MessageDispatcher to not extend deadlines of messages which arrive early to 60s#570
Merged
hannahrogers-google merged 3 commits intomasterfrom Mar 16, 2021
Merged
Conversation
…rive early to 60s
Codecov Report
@@ Coverage Diff @@
## master #570 +/- ##
=========================================
Coverage 78.83% 78.83%
Complexity 379 379
=========================================
Files 27 27
Lines 3420 3420
Branches 171 171
=========================================
Hits 2696 2696
Misses 651 651
Partials 73 73
Continue to review full report at Codecov.
|
hannahrogers-google
approved these changes
Mar 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like we had 60 second deadline extensions in the client before we attempt to update this property, on the premise that it would be updated inline. Due to code drift, this is no longer true, so I changed it to 10s (the min value) by default instead for messages which arrive before the first recalculation cycle.