Skip to content

feat: expose default client configs#541

Merged
hannahrogers-google merged 52 commits intogoogleapis:masterfrom
hannahrogers-google:partial-client-configs
Mar 11, 2021
Merged

feat: expose default client configs#541
hannahrogers-google merged 52 commits intogoogleapis:masterfrom
hannahrogers-google:partial-client-configs

Conversation

@hannahrogers-google
Copy link
Copy Markdown
Contributor

Fixes #373 ☕️

Adding delivery attempt count to PubsubMessages as a message attribute,
and creating helper function to allow users to get the count without
knowing implementation details.
@hannahrogers-google hannahrogers-google requested a review from a team February 25, 2021 21:09
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/java-pubsub API. label Feb 25, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Feb 25, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 25, 2021

Codecov Report

Merging #541 (a0c2511) into master (491b954) will increase coverage by 0.07%.
The diff coverage is 85.71%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #541      +/-   ##
============================================
+ Coverage     78.79%   78.86%   +0.07%     
- Complexity      376      377       +1     
============================================
  Files            27       27              
  Lines          3414     3416       +2     
  Branches        171      171              
============================================
+ Hits           2690     2694       +4     
+ Misses          651      650       -1     
+ Partials         73       72       -1     
Impacted Files Coverage Δ Complexity Δ
...in/java/com/google/cloud/pubsub/v1/Subscriber.java 80.61% <83.33%> (+0.09%) 23.00 <0.00> (+1.00)
...ain/java/com/google/cloud/pubsub/v1/Publisher.java 87.65% <100.00%> (+0.51%) 47.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 491b954...fe058f0. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsub Issues related to the googleapis/java-pubsub API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Check partial client side config settings

3 participants