fix: make subscriberIT test less flaky#340
Merged
hannahrogers-google merged 39 commits intogoogleapis:masterfrom Sep 4, 2020
Merged
fix: make subscriberIT test less flaky#340hannahrogers-google merged 39 commits intogoogleapis:masterfrom
hannahrogers-google merged 39 commits intogoogleapis:masterfrom
Conversation
Adding delivery attempt count to PubsubMessages as a message attribute, and creating helper function to allow users to get the count without knowing implementation details.
lettering is not enabled
Codecov Report
@@ Coverage Diff @@
## master #340 +/- ##
=========================================
Coverage 79.21% 79.21%
Complexity 318 318
=========================================
Files 21 21
Lines 2892 2892
Branches 155 155
=========================================
Hits 2291 2291
Misses 536 536
Partials 65 65 Continue to review full report at Codecov.
|
anguillanneuf
approved these changes
Sep 3, 2020
Contributor
anguillanneuf
left a comment
There was a problem hiding this comment.
Thank you for fixing the flaky test! I often had to run it twice for java8 samples tests to pass. Hope I'll no longer need to do that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The subsciberIT test is flaky because of our sync pull examples. We are expecting to receive all 10 published messages, when a pull callable might not return all of the messages (the specified number to pull is the MAX amount that will be returned, not the expected amount). To make this test less flaky, I am changing the test to publish fewer messages.
Fixes #329 ☕️