add header providers to PublisherStubSettings#294
add header providers to PublisherStubSettings#294hannahrogers-google merged 1 commit intogoogleapis:masterfrom
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Codecov Report
@@ Coverage Diff @@
## master #294 +/- ##
============================================
+ Coverage 79.18% 79.23% +0.04%
Complexity 317 317
============================================
Files 21 21
Lines 2888 2889 +1
Branches 155 155
============================================
+ Hits 2287 2289 +2
Misses 537 537
+ Partials 64 63 -1
Continue to review full report at Codecov.
|
|
Nice catch! I think you'll need to sign the contribute license agreement (CLA). |
HeaderProvider is missing from PublisherStubSettings initialisation