This repository was archived by the owner on Feb 24, 2026. It is now read-only.
fix: Accept null json values in JsonToProtoMessage converter#1288
Merged
stephaniewang526 merged 3 commits intogoogleapis:masterfrom Sep 3, 2021
yirutang:nullvalue
Merged
fix: Accept null json values in JsonToProtoMessage converter#1288stephaniewang526 merged 3 commits intogoogleapis:masterfrom yirutang:nullvalue
stephaniewang526 merged 3 commits intogoogleapis:masterfrom
yirutang:nullvalue
Conversation
stephaniewang526
approved these changes
Sep 3, 2021
Contributor
|
could you see if the test case needs to be updated? |
|
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
stephaniewang526
approved these changes
Sep 3, 2021
gcf-owl-bot bot
added a commit
that referenced
this pull request
Nov 29, 2021
* deps: upgrade google-java-format to 1.11.0 Fixes googleapis/synthtool#1287 google-java-format 1.11.0 is the version used by fmt-maven-plugin 2.12 (latest as of November 2021). * ci: owlbot to use Java 11 * formatter version through the java-shared-config * updating container_test.yaml Source-Link: googleapis/synthtool@fdf20ea Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:55d5d3c72e1c065f018e423e122a22fb55c8daa36f6f17f540774779ed659ab9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1258 ☕️