Merged
Conversation
plamut
approved these changes
Dec 13, 2021
testing/constraints-3.10.txt
Outdated
Comment on lines
+6
to
+8
| # e.g., if setup.py has "foo >= 1.14.0, < 2.0.0dev", | ||
| # Then this file should have foo==1.14.0 | ||
| uritemplate==3.0.1 No newline at end of file |
There was a problem hiding this comment.
Don't we normally pin the minimum version in the constraints file that targets the minimum Python version supported? It would IMO make sense to explain with a comment why this particular constraint lives in the constraints-3.10 file as well (unless this particular library is different).
tswast
approved these changes
Dec 13, 2021
tswast
left a comment
There was a problem hiding this comment.
I agree with Peter that a comment in the 3.10 file would be desirable, but otherwise LGTM
Contributor
Author
|
I've reverted the change to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1624 🦕