-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
remove util.dependency_for; use module cross-assignment #4689
Copy link
Copy link
Closed
Labels
alchemy 2goes along with the 2.0 milestone to aid in searchinggoes along with the 2.0 milestone to aid in searchingbig joba major change that requires a lot of knowledge and worka major change that requires a lot of knowledge and workquagmirereally hard to make the issue work "correctly" without lots of complication, riskreally hard to make the issue work "correctly" without lots of complication, risk
Milestone
Metadata
Metadata
Assignees
Labels
alchemy 2goes along with the 2.0 milestone to aid in searchinggoes along with the 2.0 milestone to aid in searchingbig joba major change that requires a lot of knowledge and worka major change that requires a lot of knowledge and workquagmirereally hard to make the issue work "correctly" without lots of complication, riskreally hard to make the issue work "correctly" without lots of complication, risk
dependency_for is going to make type annotations difficult and is also as we see in #4656 they break type annotations also. As we see in https://gerrit.sqlalchemy.org/#/c/sqlalchemy/sqlalchemy/+/1244/ we can go back to using cross-module assignment, let's see if this is feasible. I remember that there might have been some situations where nothing except dependency_for() worked, but let's give it another try.