Skip to content

fix(string-utils): detect [0,1] ranged values as numbers#388

Merged
bcoe merged 5 commits intoyargs:masterfrom
antongolub-forks:fix-str-utils-like-number
Jun 20, 2021
Merged

fix(string-utils): detect [0,1] ranged values as numbers#388
bcoe merged 5 commits intoyargs:masterfrom
antongolub-forks:fix-str-utils-like-number

Conversation

@antongolub
Copy link
Contributor

@antongolub antongolub commented May 29, 2021 •
edited
Loading

closes #389

This PR brings back detection regular decimal fractional numbers (0.1, 0.0313) as numbers.

before:

imagemin-cli %  ./cli.js --plugin.pngquant.quality={0.1,1} --plugin.foo.bar=0.2 foo.png
{
  pngquant: { quality: [ '0.1', 1 ] },
  foo: { bar: '0.2' }
}

after:

imagemin-cli %  ./cli.js --plugin.pngquant.quality={0.1,1} --plugin.foo.bar=0.2 foo
{
  pngquant: { quality: [ 0.1, 1 ] },
  foo: { bar: 0.2 }
}

This was referenced May 30, 2021
Closed
Closed
@antongolub antongolub changed the title fix(string-utils): detect 0.1 as a number like fix(string-utils): detect [0,1] ranged values as numbers May 30, 2021
@antongolub antongolub force-pushed the fix-str-utils-like-number branch from 453604b to 81b8707 Compare June 4, 2021 06:46
@antongolub
Copy link
Contributor Author

antongolub commented Jun 4, 2021

@bcoe, could you take a look?

bcoe
bcoe reviewed Jun 7, 2021
View reviewed changes
Copy link
Member

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I would like to test against yargs' suite.

@bcoe
Copy link
Member

bcoe commented Jun 20, 2021

@antongolub thank you for the contribution, works great with yargs.

@bcoe bcoe merged commit efcc32c into yargs:master Jun 20, 2021
@antongolub antongolub mentioned this pull request Aug 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bcoe bcoe bcoe approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug: numeric values in [0, 1] range are not detected as numbers

2 participants

@antongolub @bcoe