feat(plugins): typed invoke arguments for mobile plugins#8076
Merged
lucasfernog merged 19 commits intodevfrom Oct 23, 2023
Merged
feat(plugins): typed invoke arguments for mobile plugins#8076lucasfernog merged 19 commits intodevfrom
lucasfernog merged 19 commits intodevfrom
Conversation
This reverts commit 49383c2.
Member
Author
|
seems like the jackson dependency costs 1MB on the AAB size, maybe we can optimize that or find a better package for this (though AFAIK there's no Java expert on the team 😂 ) |
amrbashir
previously approved these changes
Oct 23, 2023
| // If call was made with a list of specific permission aliases to request, save them | ||
| // to be requested | ||
| val providedPerms: JSArray = invoke.getArray("permissions", JSArray()) | ||
| // TODO val providedPerms: JSArray = invoke.getArray("permissions", JSArray()) |
Member
There was a problem hiding this comment.
Why was this changed to TODO? should it be solved in this PR?
Member
Author
There was a problem hiding this comment.
oops missed this one, thanks for catching it @amrbashir
amrbashir
approved these changes
Oct 23, 2023
Member
Java yikes, do these developers exist any more 😂? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information
This PR changes the plugin command API to enforce typed arguments instead of relying on on-demand argument processing via
invoke.getString,invoke.getInt,invoke.getObjectetc.New API for Android:
New API for iOS:
Note that you can also resolve with an object instead of the generic
JSObjectclass / dictionary.