Partially revert "resolve: Update NameBindingData::vis in place"#152498
Partially revert "resolve: Update NameBindingData::vis in place"#152498rust-bors[bot] merged 2 commits intorust-lang:mainfrom
NameBindingData::vis in place"#152498Conversation
|
r? @jieyouxu rustbot has assigned @jieyouxu. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Partially revert "resolve: Update `NameBindingData::vis` in place" Partial revert of rust-lang@227e7bd. This is a minimal fix for backporting to beta, I'll submit proper fixes later. Fixes rust-lang#152004 Fixes rust-lang#151124 Fixes rust-lang#152347
Rollup of 17 pull requests Successful merges: - #142415 (Add note when inherent impl for a alias type defined outside of the crate) - #142680 (Fix passing/returning structs with the 64-bit SPARC ABI) - #150768 (Don't compute FnAbi for LLVM intrinsics in backends) - #151152 (Add FCW for derive helper attributes that will conflict with built-in attributes) - #151814 (layout: handle rigid aliases without params) - #151863 (Borrowck: simplify diagnostics for placeholders) - #152159 (Add note for `?Sized` params in int-ptr casts diag) - #152434 (Clarify names of `QueryVTable` functions for "executing" a query) - #152478 (Remove tm_factory field from CodegenContext) - #152498 (Partially revert "resolve: Update `NameBindingData::vis` in place") - #152316 (fix: add continue) - #152394 (Correctly check if a macro call is actually a macro call in rustdoc highlighter) - #152425 (Port #![test_runner] to the attribute parser) - #152481 (Use cg_ssa's produce_final_output_artifacts in cg_clif) - #152485 (fix issue#152482) - #152495 (Clean up some subdiagnostics) - #152502 (Implement `BinaryHeap::from_raw_vec`)
[beta] backports, plus stable versions in stdarch - Replace `stdarch` version placeholders with 1.94 - Parse ident with allowing recovery when trying to diagnose #151249 - Revert enabling `outline-atomics` on various platforms #151896 - Revert doc attribute parsing errors to future warnings #151952 - Remove the 4 failing tests from rustdoc-gui #152194 - Remove rustdoc GUI flaky test #152116 - Align `ArrayWindows` trait impls with `Windows` #151613 - Fix suppression of `unused_assignment` in binding of `unused_variable` #151556 - layout: handle rigid aliases without params #151814 - Fix missing unused_variables lint when using a match guard #151990 - Partially revert "resolve: Update `NameBindingData::vis` in place" #152498 - [BETA]: parse array lengths without stripping const blocks #152237 r? cuviper
Rollup of 17 pull requests Successful merges: - rust-lang/rust#142415 (Add note when inherent impl for a alias type defined outside of the crate) - rust-lang/rust#142680 (Fix passing/returning structs with the 64-bit SPARC ABI) - rust-lang/rust#150768 (Don't compute FnAbi for LLVM intrinsics in backends) - rust-lang/rust#151152 (Add FCW for derive helper attributes that will conflict with built-in attributes) - rust-lang/rust#151814 (layout: handle rigid aliases without params) - rust-lang/rust#151863 (Borrowck: simplify diagnostics for placeholders) - rust-lang/rust#152159 (Add note for `?Sized` params in int-ptr casts diag) - rust-lang/rust#152434 (Clarify names of `QueryVTable` functions for "executing" a query) - rust-lang/rust#152478 (Remove tm_factory field from CodegenContext) - rust-lang/rust#152498 (Partially revert "resolve: Update `NameBindingData::vis` in place") - rust-lang/rust#152316 (fix: add continue) - rust-lang/rust#152394 (Correctly check if a macro call is actually a macro call in rustdoc highlighter) - rust-lang/rust#152425 (Port #![test_runner] to the attribute parser) - rust-lang/rust#152481 (Use cg_ssa's produce_final_output_artifacts in cg_clif) - rust-lang/rust#152485 (fix issue#152482) - rust-lang/rust#152495 (Clean up some subdiagnostics) - rust-lang/rust#152502 (Implement `BinaryHeap::from_raw_vec`)
|
Error: Label stable-accepted can only be set by Rust team members Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #triagebot on Zulip. |
|
stable backport approved as per compiler team on Zulip. A backport PR will be authored by the release team at the end of the current development cycle. Backport labels are handled by them. |
|
stable backport declined as per compiler team on Zulip. |
|
beta backport declined as per compiler team on Zulip. |
|
beta backport approved as per compiler team on Zulip. A backport PR will be authored by the release team at the end of the current development cycle. Backport labels are handled by them. |
resolve: Extend `ambiguous_import_visibilities` deprecation lint to glob-vs-glob ambiguities Continuation of rust-lang#149596, implementation of this comment rust-lang#149596 (comment) in particular. FCP for the lint in general - rust-lang#149596 (comment). rust-lang#152498 is reverted as a part of the change, but fixes are applied to keep the tests added in that PR working. To implement this we have to have to track the most and the least visible declarations in an ambiguous glob set. Part of rust-lang#153961. r? @yaahc maybe
resolve: Extend `ambiguous_import_visibilities` deprecation lint to glob-vs-glob ambiguities Continuation of rust-lang#149596, implementation of this comment rust-lang#149596 (comment) in particular. FCP for the lint in general - rust-lang#149596 (comment). rust-lang#152498 is reverted as a part of the change, but fixes are applied to keep the tests added in that PR working. To implement this we have to have to track the most and the least visible declarations in an ambiguous glob set. Part of rust-lang#153961. r? @yaahc maybe
resolve: Extend `ambiguous_import_visibilities` deprecation lint to glob-vs-glob ambiguities Continuation of rust-lang#149596, implementation of this comment rust-lang#149596 (comment) in particular. FCP for the lint in general - rust-lang#149596 (comment). rust-lang#152498 is reverted as a part of the change, but fixes are applied to keep the tests added in that PR working. To implement this we have to have to track the most and the least visible declarations in an ambiguous glob set. Part of rust-lang#153961. r? @yaahc maybe
resolve: Extend `ambiguous_import_visibilities` deprecation lint to glob-vs-glob ambiguities Continuation of rust-lang/rust#149596, implementation of this comment rust-lang/rust#149596 (comment) in particular. FCP for the lint in general - rust-lang/rust#149596 (comment). rust-lang/rust#152498 is reverted as a part of the change, but fixes are applied to keep the tests added in that PR working. To implement this we have to have to track the most and the least visible declarations in an ambiguous glob set. Part of rust-lang/rust#153961. r? @yaahc maybe
Partial revert of 227e7bd.
This is a minimal fix for backporting to beta, I'll submit proper fixes later.
Fixes #152004
Fixes #151124
Fixes #152347