Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

fix(db_api): use correct connection attribute when handling Aborted errors#228

Merged
larkee merged 1 commit intogoogleapis:masterfrom
MaxxleLLC:spanner_issue_225
Feb 15, 2021
Merged

fix(db_api): use correct connection attribute when handling Aborted errors#228
larkee merged 1 commit intogoogleapis:masterfrom
MaxxleLLC:spanner_issue_225

Conversation

@HemangChothani
Copy link
Copy Markdown
Contributor

Fixes #225

This PR include error related unit tests to raise the coverage of "DB_API".

@HemangChothani HemangChothani requested review from a team and c24t February 8, 2021 10:57
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner API. label Feb 8, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Feb 8, 2021
@HemangChothani HemangChothani requested a review from larkee February 8, 2021 10:59
@larkee
Copy link
Copy Markdown
Contributor

larkee commented Feb 9, 2021

Thank you for making this PR! Improved test coverage is always appreciated. Are there plans to improve the coverage for google/cloud/spanner_dbapi/utils.py and google/cloud/spanner_dbapi/connection.py as well?

@HemangChothani
Copy link
Copy Markdown
Contributor Author

Yes, I will open other PR soon.

Copy link
Copy Markdown
Contributor

@larkee larkee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

@larkee larkee changed the title fix(db_api): connection attribute of connection class and include related unit tests fix(db_api): use correct connection attribute when handling Aborted errors Feb 15, 2021
@larkee larkee merged commit 4afea77 into googleapis:master Feb 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: spanner Issues related to the googleapis/python-spanner API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

db_api: cursor class doesn't have _connection attribute

2 participants