Skip to content

feat: add retry and timeout args to API methods #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gcf-merge-on-green merged 12 commits into from
Aug 12, 2020
Merged

feat: add retry and timeout args to API methods #67

gcf-merge-on-green merged 12 commits into from
Aug 12, 2020

Conversation

@tseaver
Copy link
Contributor

@tseaver tseaver commented Aug 11, 2020

Closes #3

tseaver added 10 commits August 11, 2020 15:58
@tseaver
feat: add 'retry'/'timeout' args to 'Batch.commit'
edaaa45 
Toward #3
@tseaver
feat: add 'retry'/'timeout' args to 'Client.get'/'Client.get_multi'
8dfbb2d 
Toward #3
@tseaver
feat: add 'retry'/'timeout' args to 'Client.put'/'Client.put_multi'
611dadc 
Toward #3
@tseaver
feat: add 'retry'/'timeout' args to 'Client.delete'/'Client.delete_mu…
3684244 
…lti'

Toward #3
@tseaver
feat: add 'retry'/'timeout' args to 'Client.allocate_ids'
61e44c6 
Toward #3
@tseaver
feat: add 'retry'/'timeout' args to 'Client.reserve_ids'
cb6cc90 
Toward #3
@tseaver
feat: add 'retry'/'timeout' args to 'Transaction.begin'
a20a148 
Toward #3
@tseaver
feat: add 'retry'/'timeout' args to 'Transaction.rollback'
fae7803 
Toward #3
@tseaver
feat: add 'retry'/'timeout' args to 'Transaction.commit'
bf3a417 
Toward #3
@tseaver
feat: add 'retry'/'timeout' to 'Query.fetch' and iterator.
ed2061e 
Toward #3
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 11, 2020
cguardia
cguardia approved these changes Aug 12, 2020
View reviewed changes
Copy link

@cguardia cguardia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@tseaver tseaver added the automerge Merge the pull request once unit tests and other checks pass. label Aug 12, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit f3283e1 into master Aug 12, 2020
@tseaver tseaver deleted the 3-add-retry-and-timeout branch August 12, 2020 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chrisrossi chrisrossi Awaiting requested review from chrisrossi

@crwilcox crwilcox Awaiting requested review from crwilcox

1 more reviewer

@cguardia cguardia cguardia approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Datastore: Allow retry and timeout configuration on a per instance level

2 participants

@tseaver @cguardia