Skip to content

fix: Renaming region tags to not conflict with documentation snippets #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
billyjacobson merged 1 commit into from
Jan 8, 2021
Merged

fix: Renaming region tags to not conflict with documentation snippets #190

billyjacobson merged 1 commit into from
Jan 8, 2021

Conversation

@billyjacobson
Copy link
Contributor

@billyjacobson billyjacobson commented Jan 7, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/python-bigtable API. label Jan 7, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 7, 2021
@snippet-bot
Copy link

snippet-bot bot commented Jan 7, 2021 •
edited
Loading

Here is the summary of changes.

You added 196 region tags.
You deleted 196 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@billyjacobson billyjacobson added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 7, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 7, 2021
@billyjacobson billyjacobson force-pushed the rename-api-ref-region-tags branch from 87593a1 to a9af998 Compare January 7, 2021 19:13
@billyjacobson billyjacobson marked this pull request as ready for review January 7, 2021 19:14
@billyjacobson billyjacobson requested a review from a team as a code owner January 7, 2021 19:14
@billyjacobson billyjacobson merged commit dd0cdc5 into master Jan 8, 2021
@billyjacobson billyjacobson deleted the rename-api-ref-region-tags branch January 8, 2021 15:03
@billyjacobson billyjacobson restored the rename-api-ref-region-tags branch January 8, 2021 15:03
@billyjacobson billyjacobson deleted the rename-api-ref-region-tags branch January 8, 2021 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kolea2 kolea2 kolea2 approved these changes

Assignees

No one assigned

Labels

api: bigtable Issues related to the googleapis/python-bigtable API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@billyjacobson @kolea2 @yoshi-kokoro