feat(bigquery): add support of model for extract job #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plamut
reviewed
Apr 2, 2020
Contributor
plamut
left a comment
There was a problem hiding this comment.
Looks good generally, just a few minor remarks.
google/cloud/bigquery/job.py
Outdated
| google.cloud.bigquery.table.TableReference, \ | ||
| google.cloud.bigquery.model.ModelReference \ | ||
| ]): | ||
| Table or Model into which data is to be loaded. |
Contributor
There was a problem hiding this comment.
Shouldn't this be "from which" instead for "into which", considering that it's a source?
plamut
approved these changes
Apr 6, 2020
…into bigquery_issue_60
Contributor
Author
|
@shollyman PTAL! |
shollyman
reviewed
May 7, 2020
Contributor
shollyman
left a comment
There was a problem hiding this comment.
Do we have a model lifecycle test in the integration tests? If so, let's add extraction to the lifecycle. This feature is now live so no special setup is required.
google/cloud/bigquery/job.py
Outdated
| google.cloud.bigquery.table.TableReference, \ | ||
| google.cloud.bigquery.model.ModelReference \ | ||
| ]): | ||
| Table or Model from which data is to be loaded. |
Contributor
There was a problem hiding this comment.
Maybe s/loaded/extracted/ in the comment.
Contributor
Author
There was a problem hiding this comment.
@shollyman We don't have any model lifecycle test in the integration tests.
…into bigquery_issue_60
shollyman
approved these changes
May 8, 2020
This was referenced Jul 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #60